Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove search term tab groups setting and metrics #26289

Closed
MozillaNoah opened this issue Aug 2, 2022 · 7 comments · Fixed by #26291, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed
Assignees
Milestone

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Aug 2, 2022

Follow-up from #26003 (comment)

┆Issue is synchronized with this Jira Task

@MozillaNoah MozillaNoah self-assigned this Aug 2, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 2, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 2, 2022
@MozillaNoah MozillaNoah removed needs:triage Issue needs triage eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 2, 2022
@mergify mergify bot closed this as completed in #26291 Aug 8, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 8, 2022
@Dakkaron
Copy link

This broke tab reordering.

@MozillaNoah
Copy link
Contributor Author

This broke tab reordering.

Hi @Dakkaron, this issue only removed the telemetry and the option in Settings for search term tab groups; it didn't touch any logic with tab re-ordering. We've been doing some work in the Tabs Tray recently though, so if you make a new issue to track this bug, it will have better visibility and someone will start investigating it.

@Dakkaron
Copy link

Dakkaron commented Aug 15, 2022

@MozillaNoah Hi Noah,
I reset the app's data and cache and now it's working again. Could it be that the "tab grouping is enabled" setting could have persisted and thus the tab ordering was still disabled?

Sorry for the wrong alarm

@MozillaNoah
Copy link
Contributor Author

@MozillaNoah Hi Noah, I reset the app's data and cache and now it's working again. Could it be that the "tab grouping is enabled" setting could have persisted and thus the tab ordering was still disabled?

Sorry for the wrong alarm

No worries!

Hmmm. The shared preference for search term tab groups technically would have persisted, but the logic to check for that was removed, so I'm not immediately sure. I'll do some local testing when I have a chance, and open an issue if I find anything.

@Dakkaron
Copy link

Thanks a lot!

Do you know if there are any plans to push tab ordering to the regular Firefox version? It's the biggest missing feature for me.

@MozillaNoah
Copy link
Contributor Author

MozillaNoah commented Aug 15, 2022

Thanks a lot!

Do you know if there are any plans to push tab ordering to the regular Firefox version? It's the biggest missing feature for me.

@athomasmoz or @kbrosnan might have some more context as far as business priority. With the Tabs Tray in the process of being rewritten to the new UI framework, Compose, I think re-ordering won't be live until at least the Tabs Tray is 100% converted. To that end, I just filed an issue to specifically track rewriting re-ordering into Compose.

@Dakkaron
Copy link

Thanks for opening that issue! Manual tab reordering is essential for any use case where comparing content in different tabs is necessary, e.g. comparing different products. This kind of use case is currently hardly possible in Firefox on Android.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.