Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Deduplication of sponsored shortcut URLs in "Recently Visited" and Jump Back In sections #26706

Closed
Alexandru2909 opened this issue Aug 30, 2022 · 2 comments · Fixed by #26712 or nathanmkaya/fenix#108
Closed

Deduplication of sponsored shortcut URLs in "Recently Visited" and Jump Back In sections #26706

Alexandru2909 opened this issue Aug 30, 2022 · 2 comments · Fixed by #26712 or nathanmkaya/fenix#108
Assignees
@Alexandru2909
Labels
eng:qa:verified QA Verified Feature:HomeScreen
Milestone
106

Comments

@Alexandru2909
Copy link
Contributor

Alexandru2909 commented Aug 30, 2022 •
edited by data-sync-user

Sponsored shortcuts are shown to users as shortcuts on the homepage in the second and third tile position by default, and include a “Sponsored” label. We want to prevent sponsored URLs from being displayed in the Jump back in and Recently visited in the homescreen.

More details in the Jira ticket.

┆Issue is synchronized with this Jira Task
@Alexandru2909 Alexandru2909 self-assigned this Aug 30, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 30, 2022
@Alexandru2909 Alexandru2909 removed the needs:triage Issue needs triage label Aug 30, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Aug 30, 2022
For mozilla-mobile#26706 - Change TopSite.containsQueryParameters fun…
4e76cfd 
…ction to String extension
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Aug 30, 2022
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistMidd…
3ad435c 
…leware
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 30, 2022
@github-actions github-actions bot mentioned this issue Aug 30, 2022
Merged
4 tasks
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Aug 30, 2022
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistMidd…
61be7ec 
…leware
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Aug 30, 2022
For mozilla-mobile#26706 - Change TopSite.containsQueryParameters as …
05613e7 
…Uri extension function
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Aug 30, 2022
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
0f666b3
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Aug 30, 2022
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
8a8a73b
@mergify mergify bot closed this as completed in #26712 Aug 31, 2022
mergify bot pushed a commit that referenced this issue Aug 31, 2022
@mergify
For #26706 - Change TopSite.containsQueryParameters as Uri extension …
070bf5a 
…function
mergify bot pushed a commit that referenced this issue Aug 31, 2022
@mergify
For #26706 - Add sponsored urls filter in BlocklistHandler
cedb777
@github-actions github-actions bot reopened this Aug 31, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 31, 2022
@github-actions github-actions bot added this to the 106 milestone Aug 31, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Fenix Nightly 106.0a1 (2022-09-01). After visiting sponsored shortcuts and closing the tabs I can confirm that they don not appear in the Jump back in and Recently visited sections on the homescreen.

sponsored.mp4

Devices used:

  • Samsung Galaxy S22 Ultra (Android 12)
  • OnePlus 6T (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 1, 2022
@kbrosnan kbrosnan mentioned this issue Sep 8, 2022
Closed
@github-actions github-actions bot mentioned this issue Sep 26, 2022
Merged
mergify bot pushed a commit that referenced this issue Sep 26, 2022
@mergify
For #26706 - Change TopSite.containsQueryParameters as Uri extension …
4f9a338 
…function

(cherry picked from commit 070bf5a)
mergify bot pushed a commit that referenced this issue Sep 26, 2022
@mergify
For #26706 - Add sponsored urls filter in BlocklistHandler
fd03c13 
(cherry picked from commit cedb777)

# Conflicts:
#	app/src/main/java/org/mozilla/fenix/ext/AppState.kt
#	app/src/main/java/org/mozilla/fenix/home/blocklist/BlocklistHandler.kt
#	app/src/main/java/org/mozilla/fenix/home/blocklist/BlocklistMiddleware.kt
#	app/src/test/java/org/mozilla/fenix/home/blocklist/BlocklistMiddlewareTest.kt
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Change TopSite.containsQueryParameters as …
41f8e12 
…Uri extension function

(cherry picked from commit 070bf5a)
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
3bbcb00 
(cherry picked from commit cedb777)

# Conflicts:
#	app/src/main/java/org/mozilla/fenix/ext/AppState.kt
#	app/src/main/java/org/mozilla/fenix/home/blocklist/BlocklistHandler.kt
#	app/src/main/java/org/mozilla/fenix/home/blocklist/BlocklistMiddleware.kt
#	app/src/test/java/org/mozilla/fenix/home/blocklist/BlocklistMiddlewareTest.kt
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Change TopSite.containsQueryParameters as …
b305d27 
…Uri extension function
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
960a948
@github-actions github-actions bot mentioned this issue Sep 26, 2022
Merged
4 tasks
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
137a39b
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Change TopSite.containsQueryParameters as …
7699877 
…Uri extension function
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
de88c49
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
19e8bc7
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
a06fc0e
mcarare pushed a commit to mcarare/fenix that referenced this issue Sep 26, 2022
@mcarare
For mozilla-mobile#26706 - Add sponsored urls filter in BlocklistHandler
a1ed64f
mergify bot pushed a commit that referenced this issue Sep 27, 2022
@mergify
For #26706 - Change TopSite.containsQueryParameters as Uri extension …
9bb2627 
…function
mergify bot pushed a commit that referenced this issue Sep 27, 2022
@mergify
For #26706 - Add sponsored urls filter in BlocklistHandler
57295d7
@LaurentiuApahideanSV
Copy link

I retested the issue on Fenix RC 105.2.0. After visiting sponsored shortcuts and closing the tabs I can confirm that they don not appear in the Jump back in and Recently visited sections on the homescreen.

Devices used:

  • Samsung Galaxy S22 Ultra (Android 12)
  • Huawei MediaPad M3 (Android 7)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
eng:qa:verified QA Verified Feature:HomeScreen
Projects
None yet
Milestone
106
2 participants
@Alexandru2909 @LaurentiuApahideanSV