Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Enable TCP by default in ETP Standard, Strict, and Custom modes #26910

Closed
cpeterso opened this issue Sep 9, 2022 · 1 comment · Fixed by #26940, fork-house/fenix#13 or nathanmkaya/fenix#108
Closed

Enable TCP by default in ETP Standard, Strict, and Custom modes #26910

cpeterso opened this issue Sep 9, 2022 · 1 comment · Fixed by #26940, fork-house/fenix#13 or nathanmkaya/fenix#108
Assignees
@Mugurell
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone
106

Comments

@cpeterso
Copy link

cpeterso commented Sep 9, 2022 •
edited by data-sync-user
Loading

The TCP setting ("Isolate cross-site cookies") was added to ETP's custom settings in #26869, but now we would like to enable TCP by default in ETP Standard, Strict, and Custom modes. Also, TCP should be disabled when ETP is disabled.

Assigning to @Mugurell because he fixed #26869.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 9, 2022
@cpeterso cpeterso mentioned this issue Sep 9, 2022
Closed
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 12, 2022
@Mugurell
For mozilla-mobile#26910: Enable TCP for all modes
a4fa4cc 
Unify the TCP feature with the TCP setting allowing both to be controlled
through the same Nimbus experiment.
Allow changing the default cookie policy to TCP based on the Nimbus experiment.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 12, 2022
@github-actions github-actions bot mentioned this issue Sep 12, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 12, 2022
@Mugurell
For mozilla-mobile#26910: Enable TCP for all modes
49bccbd 
Unify the TCP feature with the TCP setting allowing both to be controlled
through the same Nimbus experiment.
Allow changing the default cookie policy to TCP based on the Nimbus experiment.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 12, 2022
@Mugurell
For mozilla-mobile#26910: Enable TCP for all modes
5d43d10 
Unify the TCP feature with the TCP setting allowing both to be controlled
through the same Nimbus experiment.
Allow changing the default cookie policy to TCP based on the Nimbus experiment.
mergify bot pushed a commit that referenced this issue Sep 12, 2022
@Mugurell @mergify
For #26910: Enable TCP for all modes
9361543 
Unify the TCP feature with the TCP setting allowing both to be controlled
through the same Nimbus experiment.
Allow changing the default cookie policy to TCP based on the Nimbus experiment.
@mergify mergify bot closed this as completed in #26940 Sep 12, 2022
@github-actions github-actions bot reopened this Sep 12, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 12, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 12, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Fenix Nightly 106.0a1 2022-09-13 and the Total cookie protection feature is enable by default in all modes.

Devices used:

  • Google Pixel 6 (Android 13)
  • Samsung Galaxy S22 Ultra (Android 12)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 13, 2022
This was referenced Oct 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Milestone
106
3 participants
@cpeterso @Mugurell @LaurentiuApahideanSV