Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove code that re-enables old Fennec extensions when they are re-supported in Fenix #26911

Closed
cpeterso opened this issue Sep 9, 2022 · 4 comments · Fixed by #27539, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Assignees
Labels
eng:qa:not-needed Added by QA to issues that cannot be tested Feature:FennecTransition Feature:WebExtensions needs:triage Issue needs triage
Milestone

Comments

@cpeterso
Copy link

cpeterso commented Sep 9, 2022

For Fenix users that have a migrated Fennec profile, we have some code that will try re-enable old extension if the extensions are "re-supported" in a new Fenix version. We don't want old, untested Fennec 68 extensions to be automatically re-enabled in Fenix.

When we "re-support" an old extension for Fenix, we want the extension to reappear in Fenix's Add-ons UI, but stay disabled until the user manually re-enables it in the Add-ons UI.

TBD: Do we need to force an AMO update check when re-supporting an extension? Fenix has not been updating unsupported Fennec extensions, so users will have a very old version. Fenix checks AMO for new extension updates every 12 hours, so maybe that's frequent enough we don't need to force an update? What is the likelihood that an old extension would be re-supported and the user notices it in their Add-ons UI and manually re-enables it before the 12-hour extension update check?

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Sep 9, 2022
@cpeterso cpeterso changed the title Remove extension reactivation code for legacy Fennec extensions Remove code that re-enables old Fennec extensions when they are re-supported in Fenix Sep 9, 2022
@Amejia481
Copy link
Contributor

To add more details:

  • Here is where we check and enable migrated add-ons, at the moment we would like to remove the notification and the enabling part, instead we would like to update any migrated add-on.

  • For users to be able to enable back the add-ons, they will need to go to the UI and manually re-enable, but we will need to update Fenix to support that use case, on the installed add-on screen every time user hit enable, we will need enable twice for those add-ons, one with the flag source: EnableSource = EnableSource.APP_SUPPORT and another with source: EnableSource = EnableSource.USER, hints on how to detect if the add-on was migrated.

@Alexandru2909 Alexandru2909 self-assigned this Oct 24, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 25, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 25, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Oct 27, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 1, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 1, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 1, 2022
@mergify mergify bot closed this as completed in #27539 Nov 1, 2022
@github-actions github-actions bot added this to the 108 milestone Nov 1, 2022
@github-actions github-actions bot reopened this Nov 1, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 1, 2022
@delia-pop
Copy link

@cpeterso We attempted to test this using a Fennec build from here. The thought process was to sign in with a valid Firefox account > install several extensions > update to Fenix and sign in with the same account.
However:

  • we were not able to access the "Sign in" page from Fennec;
  • updating Fennec to Fenix does not work, as Fenix is not overwriting Fenix, instead is installed individually.

Without syncing the account we are not able to verify this issue. Is there a workaround or a better option?

1667402049534

@cpeterso
Copy link
Author

cpeterso commented Nov 2, 2022

@delia-pop Summarizing a conversation from Slack: given these Fennec issues, I don't think testing this would be a good use of your time. This is expected to be a tiny corner case, so I think you can close this issue

This code change was made to protect Fenix users from ancient versions of Fennec add-ons that might be reactivated before Fenix has a chance to install the add-ons' latest version from AMO.

@delia-pop
Copy link

Understood, thank you for further inquiring. I will close this ticket and remove the QA needed label.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.