Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: The wallpaper on homepage is removed after accessing the Settings menu #26999

Closed
delia-pop opened this issue Sep 15, 2022 · 5 comments · Fixed by #27034 or fork-house/fenix#13
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Wallpapers needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Milestone

Comments

@delia-pop
Copy link

delia-pop commented Sep 15, 2022

Steps to reproduce

  1. Have an old version with a wallpaper set. > Update the app to latest version.
  2. OR fresh install the latest version > Set a wallpaper from the Wallpapers Settings menu.
  3. Observe the homepage.
  4. Access a webpage/access the Settings menu and return to homepage. Observe the wallpaper on homepage.
  5. Restart the app and observe the homepage.

Expected behaviour

The wallpaper set remains displayed on homepage when accessing different screens and returning to homepage.

Actual behaviour

After dismissing the onboarding, the wallpaper set in Steps 1 or 2 is displayed on homepage.
However:

  • Opening a webpage and browsing does not remove the wallpaper;
  • Restarting the app does not remove the wallpaper, but issue [Bug]: Wallpaper loading on launch is delayed #26511 can be observed at launch;
  • Accessing Settings and returning to homepage, removes the wallpaper from homepage, but after opening a page or restarting the app, the wallpaper is displayed again.

Device name

Google Pixel 6

Android version

Android 13

Firefox release type

Firefox Nightly

Firefox version

Nightly 106.0a1 from 09/14 and 09/15

Device logs

No response

Additional information

screen-20220915-104207_Trim.mp4

┆Issue is synchronized with this Jira Task

@delia-pop delia-pop added 🐞 bug Crashes, Something isn't working, .. S3 Blocks non-critical functionality and a work around exists needs:triage Issue needs triage Feature:Wallpapers labels Sep 15, 2022
@delia-pop delia-pop changed the title [Bug]: The wallpaper on homepage is removed after accessing the Settings menu for upgrading users [Bug]: The wallpaper on homepage is removed after accessing the Settings menu Sep 15, 2022
@quadriflax
Copy link

Starting with the below version, I'm getting a pop up message that reads "Couldn't change wallpaper" on my Samsung Tab A 10.1 (2019) with A11. This happens when loading to homescreen. I suspect it's related to this and the previously closed out bugs causing it to not load/become unresponsive, so I'm making note here.

106.0a1 (Build #2015904169), 7fc96b0+
AC: 106.0.20220914204738, 592037c406
GV: 106.0a1-20220914154803
AS: 94.2.0

@delia-pop
Copy link
Author

delia-pop commented Sep 15, 2022

Hi, @quadriflax, thank you for the input. Indeed, the "Couldn't change wallpaper" snackbar message should be displayed when the wallpaper couldn't be selected due to a certain error. I did not encounter this so far but I will keep an eye on it. Can you share a video recording of the issue?

@quadriflax
Copy link

Hi, @quadriflax, thank you for the input. Indeed, the "Couldn't change wallpaper" snackbar message should be displayed when the wallpaper couldn't be selected due to a certain error. I did not encounter this so far but I will keep an eye on it. Can you share a video recording of the issue?

I can do a screenshot. This just pops up and goes away a second or two later.

Screenshot_20220915-053921_Firefox Nightly

@mavduevskiy mavduevskiy self-assigned this Sep 15, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Sep 15, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 15, 2022
@mergify mergify bot closed this as completed in #27034 Sep 15, 2022
@github-actions github-actions bot added this to the 106 milestone Sep 15, 2022
@github-actions github-actions bot reopened this Sep 15, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 15, 2022
@delia-pop
Copy link
Author

Verified as fixed on the latest Nightly 106 from 09/16 with Google Pixel 6 (Android 13). The wallpaper is no longer removed after returning from Settings.
We tested this for an upgrading user with a wallpaper set on an older Fenix version, since due to #26997 wallpapers are not displayed.

screen-20220916-092452_Trim.mp4

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 16, 2022
@quadriflax
Copy link

I'm still getting the popup error with version below. Is this a separate issue, then?

106.0a1 (Build #2015904361), 9822a2d+
AC: 106.0.20220915212218, 7745ebc7f1
GV: 106.0a1-20220915171049
AS: 94.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Wallpapers needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Projects
None yet
3 participants