Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: After dismissing the onboarding, a shared tab from external apps is displayed on homepage instead of being opened in new tab #27016

Closed
delia-pop opened this issue Sep 15, 2022 · 2 comments · Fixed by #27305 or nathanmkaya/fenix#108
Closed

[Bug]: After dismissing the onboarding, a shared tab from external apps is displayed on homepage instead of being opened in new tab #27016

delia-pop opened this issue Sep 15, 2022 · 2 comments · Fixed by #27305 or nathanmkaya/fenix#108
Assignees
@Mugurell
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Milestone
107

Comments

@delia-pop
Copy link

delia-pop commented Sep 15, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Have an older Fenix version installed and Fenix set as default browser.
  2. Update Fenix to the latest version, but don't open the app yet.
  3. Go to an external app and share a tab/article with Fenix.
  4. Once Fenix is opened, dismiss the Onboarding cards.
  5. Observe if the tab shared in Step 3 is opened properly.

Expected behaviour

The shared article should be opened directly in a new tab.

Actual behaviour

The shared article is displayed in the "Jump back in" section on Homepage.

Device name

Google Pixel 6

Android version

Android 13

Firefox release type

Firefox Nightly

Firefox version

Nightly 106.0a1 from 09/15

Device logs

No response

Additional information

Observed while testing the scenario in #26985 .
Note that this issue does not occur for a new user. When opening a link directly in Fenix, it is opened as a new tab.

ExternIntent_Trim.mp4

┆Issue is synchronized with this Jira Task
@delia-pop delia-pop added 🐞 bug Crashes, Something isn't working, .. Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR S3 Blocks non-critical functionality and a work around exists needs:triage Issue needs triage labels Sep 15, 2022
@Mugurell
Copy link
Contributor

Mugurell commented Sep 19, 2022 •
edited
Loading

We probably shouldn't show the new onboarding when the app is launched from an external url - issue discussed here - #26985 so when that's fixed the scenario for this bug would not exist anymore.
So this issue should be checked again after #26985.

@delia-pop delia-pop mentioned this issue Sep 23, 2022
Closed
@Mugurell Mugurell self-assigned this Oct 5, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 6, 2022
@Mugurell
For mozilla-mobile#27016 - Prevent the MR onboarding always going to …
d87fd73 
…homescreen

This will mean that hen the onboarding is finished the user will get back to
the screen that should've been opened if not the onboarding.
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 6, 2022
@Mugurell
For mozilla-mobile#27016 - Ensure smooth search UX after the MR onboa…
2684e5d 
…rding is closed

If the app is opened from the search widget and the MR onboarding is shown then
the backstack will have the following structure:
- root, homeFragment, searchDialogFragment, onboardingFragment
as opposed to otherwise
- root, homeFragment, searchDialogFragment.

This patch allows to avoid the MR onboarding fragment causing the
SearchDialogFragment to not know that below it is the HomeFragment and
consequently not applying transparency or propagate user touches to the parent
Activity.
@github-actions github-actions bot mentioned this issue Oct 6, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 6, 2022
@Mugurell Mugurell mentioned this issue Oct 6, 2022
Closed
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 7, 2022
@Mugurell
For mozilla-mobile#27016 - Prevent the MR onboarding always going to …
6a4a29e 
…homescreen

This will mean that hen the onboarding is finished the user will get back to
the screen that should've been opened if not the onboarding.
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 7, 2022
@Mugurell
For mozilla-mobile#27016 - Ensure smooth search UX after the MR onboa…
48ae7f0 
…rding is closed

If the app is opened from the search widget and the MR onboarding is shown then
the backstack will have the following structure:
- root, homeFragment, searchDialogFragment, onboardingFragment
as opposed to otherwise
- root, homeFragment, searchDialogFragment.

This patch allows to avoid the MR onboarding fragment causing the
SearchDialogFragment to not know that below it is the HomeFragment and
consequently not applying transparency or propagate user touches to the parent
Activity.
@mergify mergify bot closed this as completed in #27305 Oct 10, 2022
mergify bot pushed a commit that referenced this issue Oct 10, 2022
@Mugurell @mergify
For #27016 - Prevent the MR onboarding always going to homescreen
6c6c3f5 
This will mean that hen the onboarding is finished the user will get back to
the screen that should've been opened if not the onboarding.
mergify bot pushed a commit that referenced this issue Oct 10, 2022
@Mugurell @mergify
For #27016 - Ensure smooth search UX after the MR onboarding is closed
47b7336 
If the app is opened from the search widget and the MR onboarding is shown then
the backstack will have the following structure:
- root, homeFragment, searchDialogFragment, onboardingFragment
as opposed to otherwise
- root, homeFragment, searchDialogFragment.

This patch allows to avoid the MR onboarding fragment causing the
SearchDialogFragment to not know that below it is the HomeFragment and
consequently not applying transparency or propagate user touches to the parent
Activity.
@github-actions github-actions bot reopened this Oct 10, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Oct 10, 2022
@github-actions github-actions bot added this to the 107 milestone Oct 10, 2022
@delia-pop
Copy link
Author

Verified as fixed on the latest Nightly 107.0a1 from 10/11 with Google Pixel 6 (Android 13). After sharing an article with Fenix/opening a link from another app, Fenix is launched and the Onboarding is displayed. Once the cards are dismissed, the page is correctly opened in a new tab or custom tab.

SharedArticle.mp4
CustomTab.mp4
OpenLink.mp4

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 11, 2022
@Mugurell Mugurell mentioned this issue Oct 20, 2022
Closed
@github-actions github-actions bot mentioned this issue Nov 9, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#27016 - Prevent the MR onboarding al…
0866604 
…ways going to homescreen

This will mean that hen the onboarding is finished the user will get back to
the screen that should've been opened if not the onboarding.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#27016 - Ensure smooth search UX afte…
4296eb9 
…r the MR onboarding is closed

If the app is opened from the search widget and the MR onboarding is shown then
the backstack will have the following structure:
- root, homeFragment, searchDialogFragment, onboardingFragment
as opposed to otherwise
- root, homeFragment, searchDialogFragment.

This patch allows to avoid the MR onboarding fragment causing the
SearchDialogFragment to not know that below it is the HomeFragment and
consequently not applying transparency or propagate user touches to the parent
Activity.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Onboarding First Run, Contextual Feature Recommendation/Recommender CFR needs:triage Issue needs triage S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
107
2 participants
@Mugurell @delia-pop