Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor Glean metrics abstraction to be less error prone #2706

Closed
sblatz opened this issue May 21, 2019 · 1 comment
Closed

Refactor Glean metrics abstraction to be less error prone #2706

sblatz opened this issue May 21, 2019 · 1 comment
Assignees
@sblatz
Labels
E5 Estimation Point: about 5 days eng:health Improve code health Feature:Telemetry P1 Current sprint
Milestone
v1.4

Comments

@sblatz
Copy link
Contributor

sblatz commented May 21, 2019 •
edited by data-sync-user

Currently we are hardcoding strings that map Glean metrics from the metrics.yaml file to the extras passed in inside metrics.kt. This leads to crashes like #2688 as we have no safeguards to ensure that the metrics align. This is especially worrisome because, by default, telemetry events do not get send in dev builds, so an unsuspecting dev could believe they were testing properly and still ship a crash (which is what happened in my case 😅: #2705 )

It would be great if we could implement a system that would automatically detects these misalignment (or at least test for them before being merged in). This will help us avoid many similar crashes in the future.

┆Issue is synchronized with this Jira Task
@sblatz sblatz added eng:health Improve code health Feature:Telemetry labels May 21, 2019
@vesta0 vesta0 added this to the Dev Stories Backlog milestone May 28, 2019
@boek boek removed this from the Dev Stories Backlog milestone Jul 17, 2019
@sblatz sblatz added the P2 Upcoming release label Jul 19, 2019
@sblatz sblatz added this to Prioritized Eng Backlog in Fenix Sprint Kanban Jul 19, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Aug 8, 2019

We should use metrics.yaml as a source of truth. See this document for meeting notes with Glean.

@sblatz sblatz added P1 Current sprint and removed P2 Upcoming release labels Aug 9, 2019
@sblatz sblatz changed the title Implement detection of misaligned metric "extras" Refactor Glean metrics abstraction to be less error prone Aug 9, 2019
@sblatz sblatz added the E5 Estimation Point: about 5 days label Aug 9, 2019
@sblatz sblatz mentioned this issue Aug 9, 2019
Closed
@sblatz sblatz self-assigned this Aug 15, 2019
@sblatz sblatz moved this from Prioritized Eng Backlog to In Progress in Fenix Sprint Kanban Aug 15, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Remove else case in GleanMetricsService
2c40bd5
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
9e59d4d
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
efb35c7
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
d0d8d6c
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
028eecd
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
cb85860
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
0a4e30a
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
feaf156
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
610b7f0
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
01832fc
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
93d0ae2
sblatz added a commit to sblatz/fenix that referenced this issue Aug 15, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
a9096dc
sblatz added a commit to sblatz/fenix that referenced this issue Aug 19, 2019
@sblatz
For mozilla-mobile#2706: Adds recording for untracked events
df80bb0
sblatz added a commit to sblatz/fenix that referenced this issue Aug 19, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
cbea31c
sblatz added a commit to sblatz/fenix that referenced this issue Aug 19, 2019
@sblatz
For mozilla-mobile#2706: Adds key alignment to Metrics
5577578
boek pushed a commit that referenced this issue Aug 19, 2019
@sblatz @boek
For #2706: Refactor Glean to reduce errors (#4753)
0d4ecee 
* For #2706: Adds recording for untracked events

* For #2706: Adds key alignment to Metrics
@sblatz sblatz closed this as completed Aug 20, 2019
Fenix Sprint Kanban automation moved this from In Progress to Done Aug 20, 2019
@colintheshots colintheshots added this to the v1.4 milestone Aug 30, 2019
@data-sync-user data-sync-user changed the title Refactor Glean metrics abstraction to be less error prone FNX2-18212 ⁃ Refactor Glean metrics abstraction to be less error prone Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18212 ⁃ Refactor Glean metrics abstraction to be less error prone FNX3-16523 ⁃ Refactor Glean metrics abstraction to be less error prone Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX3-16523 ⁃ Refactor Glean metrics abstraction to be less error prone Refactor Glean metrics abstraction to be less error prone Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
E5 Estimation Point: about 5 days eng:health Improve code health Feature:Telemetry P1 Current sprint
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
6 participants
@kbrosnan @colintheshots @boek @sblatz @vesta0 @data-sync-user