Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #2706: Refactor Glean to reduce errors #4753

Merged
merged 2 commits into from
Aug 19, 2019
Merged

For #2706: Refactor Glean to reduce errors #4753

merged 2 commits into from
Aug 19, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Aug 15, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz sblatz force-pushed the fix-glean branch 5 times, most recently from cb85860 to 0a4e30a Compare August 15, 2019 16:27
@codecov-io

This comment has been minimized.

Sign in to view
sblatz
sblatz commented Aug 15, 2019
View reviewed changes
app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt Outdated
get() = null
}

// TODO: Can we get rid of string mapping here?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for string mapping here :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pattern matching the Fact which is from A-C converting it to an Event. So no need to change anything here. Tests wouldn't hurt though :D

@sblatz sblatz marked this pull request as ready for review August 15, 2019 20:54
@sblatz sblatz requested a review from a team as a code owner August 15, 2019 20:54
@sblatz sblatz requested a review from boek August 15, 2019 20:54
boek
boek reviewed Aug 19, 2019
View reviewed changes
app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt Outdated
// Don't track other events with Glean
else -> null
// Don't record other events in Glean:
is Event.AddBookmark -> { null }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think we need brackets around null here

app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt Outdated
get() = null
}

// TODO: Can we get rid of string mapping here?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pattern matching the Fact which is from A-C converting it to an Event. So no need to change anything here. Tests wouldn't hurt though :D

app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt Outdated Show resolved Hide resolved
@boek
Copy link
Contributor

boek commented Aug 19, 2019

Can we get a data review for the new metrics (if there wasn't one already?) :)

@sblatz sblatz mentioned this pull request Aug 19, 2019
Closed
@sblatz
Copy link
Contributor Author

sblatz commented Aug 19, 2019

Only new event we're adding is selected for search shortcuts. Here is the data review for it:

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users select a search engine with the search shortcut menu
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • To measure how often users select an engine from the search shortcut menu. This will help us determine if the feature is useful or should be tweaked in some way.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this event. We have events for opening and closing this menu but not for actually selecting an engine.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 03/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from boek August 19, 2019 21:57
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Aug 19, 2019
sblatz
sblatz commented Aug 19, 2019
View reviewed changes
app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt
@@ -23,7 +22,9 @@ class FenixOnboarding(context: Context) {

fun finish() {
onboardingPrefs.onboardedVersion = CURRENT_ONBOARDING_VERSION
metrics.track(Event.DismissedOnboarding)

// To be fixed in #4824
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally leaving this here. Hoping I can pull this in this sprint.

boek
boek approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, with metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, in the Fenix settings

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry, Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    All data is category 2.

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry. Fenix team will monitor

  9. Does the data collection use a third-party collection tool?
    No

@boek boek merged commit 0d4ecee into mozilla-mobile:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boek boek boek approved these changes

Assignees
No one assigned
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sblatz @codecov-io @boek