Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

The transition between Private Browsing and Normal Browsing is not smooth when a wallpaper is set #27120

Closed
delia-pop opened this issue Sep 23, 2022 · 5 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing Feature:Toolbar Address bar, see also Feature:Search Feature:Wallpapers needs:triage Issue needs triage S4 Minor significance, cosmetic issues, low or no impact to users

Comments

@delia-pop
Copy link

delia-pop commented Sep 23, 2022

Steps to reproduce

  1. Launch Fenix
  2. Set a wallpaper from the Wallpapers Settings menu.
  3. Return to the homepage and tap on the Private Browsing icon.
  4. Tap again on the PB icon to return to homepage. Observe the toolbar color.

Expected behaviour

The transition between Private Browsing and Normal Browsing is smooth, without visual defects.

Actual behaviour

The transition between Private Browsing and Normal Browsing is slower, the toolbar is still displayed in the PB color for a split second after the Normal Browsing mode was entered and the wallpaper displayed.

Device name

Google Pixel 6

Android version

Android 13

Firefox release type

Firefox Nightly

Firefox version

107.0a1 from 09/22

Device logs

No response

Additional information

The issue was initially discussed over #26644 .
Further testing revealed that the issues was introduced first in Nightly 106.0a1 from 09/14 after #26511 was fixed.
Also reproducible in Beta 106.0b1.

PBModeTransition.mp4

┆Issue is synchronized with this Jira Task

@delia-pop delia-pop added 🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing Feature:Toolbar Address bar, see also Feature:Search needs:triage Issue needs triage S4 Minor significance, cosmetic issues, low or no impact to users Feature:Wallpapers labels Sep 23, 2022
@cpeterso
Copy link

Not a blocker for MR.

@MatthewTighe - Do you know why switching from private browsing to normal browsing would be slower with a wallpaper?

@MatthewTighe
Copy link
Contributor

Loading and displaying the wallpaper will have some impact on performance. The difference in the toolbar's color changing and the rest of the home screen rendering seems pretty annoying though. It's possible we could do something similar to what @Mugurell did in #27105 to improve that, though I don't know for sure.

@cpeterso
Copy link

We don't need to fix this bug for MR v106. We can take a look in v108 (and maybe uplift to Beta v107).

@MatthewTighe
Copy link
Contributor

Stepping through the video, it looks like we may just need to wait to apply the wallpaper until after the theme is applied to get a more visually consistent experience.

  • Private browsing

Screen Shot 2022-09-23 at 1 01 57 PM

  • Wallpaper applied

image

  • Home screen content renders and theme applies

Screen Shot 2022-09-23 at 1 03 29 PM

@cpeterso cpeterso changed the title [Bug]: The transition between Private Browsing and Normal Browsing is not smooth when a wallpaper is set The transition between Private Browsing and Normal Browsing is not smooth when a wallpaper is set Dec 26, 2022
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807530

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:PrivateBrowsing Feature:Toolbar Address bar, see also Feature:Search Feature:Wallpapers needs:triage Issue needs triage S4 Minor significance, cosmetic issues, low or no impact to users
Projects
None yet
Development

No branches or pull requests

3 participants