Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Home screen logo and private browsing button colors should be adapted to wallpapers. #26644

Closed
mcarare opened this issue Aug 25, 2022 · 4 comments · Fixed by #27009, #27105, #27368, fork-house/fenix#13 or nathanmkaya/fenix#108
Assignees
Labels
eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged Feature:HomeScreen Feature:Wallpapers Needs-UX Issues or tickets that need UX input or review
Milestone

Comments

@mcarare
Copy link
Contributor

mcarare commented Aug 25, 2022

When using certain wallpapers, the Firefox logo and the PB button are not very visible.

We should have the ability to adapt colors in order to provide a good contrast ratio.

cc: @Kate-Galetski

┆Issue is synchronized with this Jira Task

@mcarare mcarare added Feature:HomeScreen Feature:Wallpapers Needs-UX Issues or tickets that need UX input or review labels Aug 25, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 25, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Aug 25, 2022
@Mugurell Mugurell self-assigned this Sep 15, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 15, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 15, 2022
… the Fenix logo

And to the private mode switcher.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 15, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 16, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 16, 2022
… the Fenix logo

And to the private mode switcher.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 19, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 19, 2022
… the Fenix logo

And to the private mode switcher.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 20, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 20, 2022
… the Fenix logo

And to the private mode switcher.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 21, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 21, 2022
… the Fenix logo

And to the private mode switcher.
Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 21, 2022
… the Fenix logo

And to the private mode switcher.
@mergify mergify bot closed this as completed in #27009 Sep 21, 2022
mergify bot pushed a commit that referenced this issue Sep 21, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
mergify bot pushed a commit that referenced this issue Sep 21, 2022
@github-actions github-actions bot reopened this Sep 21, 2022
@github-actions github-actions bot added this to the 107 milestone Sep 21, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Sep 21, 2022
@delia-pop
Copy link

delia-pop commented Sep 22, 2022

We tested this on 107.0a1 from 09/22 with Xiaomi Pad5 (Android 11), Google Pixel 6 (Android 13), Xiaomi 12 Pro (Android 12), Lenovo Yoga Tab 11 (Android 11), LG G7 fit (Android 8.1.0), Xiaomi Redmi Note 8T (Android 9) and One Plus 9 PRO (Android 12). The following were observed:

  • on all devices: When returning from Private Browsing mode, the PB icon is improperly displayed for a split second as a solid white/dark circle depending on the theme used, but only when a wallpaper it set.
screen-20220922-131711.mp4
  • on Xiaomi Pad5 (Android 11) (which might be prone to color issues) : When entering Private Browsing mode, the PB icon is displayed as a solid white/dark circle depending on the theme used, regardless of whether a wallpaper is set or not.
Screenrecorder-2022-09-22-12-50-04-846.mp4

@Mugurell
Copy link
Contributor

Mugurell commented Sep 22, 2022

Interesting issue.
Going by the first video I see 3 stages for when switching to normal mode which I think shows the problem:

private mode in-between normal mode

So there is an overarching issue: slow transition that affects not only the private browsing button.
And then the issue with the private browsing button is the result of the race stemming from the above issue between:

  • the background which stays the same until private mode is fully off - in the middle image we see the toolbar still in private mode
  • the new tint that is applied earlier - in the middle image we see the normal mode wallpaper - which will apply it's textColor to the logo and private browsing button.

So as a solution here we should also change for the private browsing button both the background and the image to ensure consistency.

Mugurell added a commit to Mugurell/fenix that referenced this issue Sep 22, 2022
… browsing button

This will help avoid a race between the two layers of the svg, with previously
only changing the color for just one.
By applying the new theme to the button when needing to apply the textColor
from wallpaper it will automatically use the right
@mergify mergify bot closed this as completed in #27105 Sep 27, 2022
mergify bot pushed a commit that referenced this issue Sep 27, 2022
This will help avoid a race between the two layers of the svg, with previously
only changing the color for just one.
By applying the new theme to the button when needing to apply the textColor
from wallpaper it will automatically use the right
@github-actions github-actions bot reopened this Sep 27, 2022
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Sep 27, 2022
@delia-pop
Copy link

Verified as fixed on Nightly 107.0a1 from 09/27 with Google Pixel 6 (Android 13), Xiaomi 12 Pro (Android 12), Lenovo Yoga Tab 11 (Android 11) and Xiaomi Pad5 (Android 12). The private browsing button remains properly displayed when entering/returning from the PB mode while a wallpaper is set.

screen-20220927-172619.mp4

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 27, 2022
mergify bot pushed a commit that referenced this issue Sep 27, 2022
This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.

(cherry picked from commit 103a0cb)
mergify bot pushed a commit that referenced this issue Sep 27, 2022
And to the private mode switcher.

(cherry picked from commit 7b5ba84)
MatthewTighe pushed a commit that referenced this issue Sep 27, 2022
…o (backport #27009) (#27196)

* For #26644 - Split the Fenix logo in two images

This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.

(cherry picked from commit 103a0cb)

* For #26644 - Apply the wallpaper provided text color to the Fenix logo

And to the private mode switcher.

(cherry picked from commit 7b5ba84)

Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
mergify bot pushed a commit that referenced this issue Sep 28, 2022
This will help avoid a race between the two layers of the svg, with previously
only changing the color for just one.
By applying the new theme to the button when needing to apply the textColor
from wallpaper it will automatically use the right

(cherry picked from commit c7c5682)
MatthewTighe pushed a commit that referenced this issue Sep 28, 2022
…on (#27204)

This will help avoid a race between the two layers of the svg, with previously
only changing the color for just one.
By applying the new theme to the button when needing to apply the textColor
from wallpaper it will automatically use the right

(cherry picked from commit c7c5682)

Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>
@delia-pop
Copy link

Verified as fixed on Beta 106.0b3 as well, with Lenovo Yoga Tab 11 (Android 11).

@Mugurell Mugurell modified the milestones: 107, 106 Sep 30, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 11, 2022
…he new theme earlier to the private browsing button"

This reverts commit c7c5682 given that the
severity of the new issue is much higher.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 11, 2022
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 11, 2022
…he new theme earlier to the private browsing button"

This reverts commit c7c5682 given that the
severity of the new issue is much higher.
mergify bot pushed a commit that referenced this issue Oct 12, 2022
…private browsing button"

This reverts commit c7c5682 given that the
severity of the new issue is much higher.
interfect added a commit to fork-maintainers/iceraven-browser that referenced this issue Jan 8, 2023
commit ca78b5c
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Sat Jan 7 22:35:37 2023 +0800

    update workflow status badge

commit 2805a67
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Sat Jan 7 18:43:51 2023 +0800

    add toolbar menu option to show display name instead of email

commit 7aeee0d
Merge: 68112c0 78718ba
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Sat Jan 7 14:25:24 2023 +0800

    Merge tag 'v108.2.0' into fork

commit 68112c0
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Fri Jan 6 22:00:43 2023 +0800

    update resources for iceraven

commit ed1b338
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Thu Jan 5 23:31:39 2023 +0800

    change gradle memory limit

commit acaad04
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Thu Jan 5 20:37:04 2023 +0800

    migrate to MenuProvider

commit 025493a
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Thu Jan 5 19:33:55 2023 +0800

    remove topsheetbehavior

commit f4a0127
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Thu Jan 5 16:50:33 2023 +0800

    revert some code and fix merge

commit 6ec7bb2
Merge: 34794df 6897084
Author: akliuxingyuan <akliuxingyuan@gmail.com>
Date:   Thu Jan 5 16:00:24 2023 +0800

    Merge branch 'fenix/108.1.1' into fork

commit 34794df
Author: Adam Novak <interfect@gmail.com>
Date:   Wed Nov 2 22:08:34 2022 -0400

    Add a Java distribution

commit 7e1b8e9
Author: Adam Novak <interfect@gmail.com>
Date:   Wed Nov 2 21:42:02 2022 -0400

    Upgrade our source of Gradle and try to watch its resources

commit b307fc5
Author: Adam Novak <interfect@gmail.com>
Date:   Mon Oct 31 21:06:28 2022 -0400

    Move stacktrace option

commit 01e0d28
Author: Adam Novak <interfect@gmail.com>
Date:   Mon Oct 31 21:02:34 2022 -0400

    Generalize the build and release actions into one turbo-action

commit ac5b419
Author: Adam Novak <interfect@gmail.com>
Date:   Mon Oct 31 20:53:59 2022 -0400

    Add random Gradle options

commit 9057a21
Author: Adam Novak <interfect@gmail.com>
Date:   Mon Oct 31 20:40:54 2022 -0400

    Turn off some unused Mozilla workflows

commit 2c3c769
Author: Adam Novak <interfect@gmail.com>
Date:   Mon Oct 31 20:39:51 2022 -0400

    Roll back to the README we actually want

commit f5b84ec
Author: Adam Novak <interfect@gmail.com>
Date:   Sun Oct 30 14:55:31 2022 -0400

    Attempt to keep Gradle build daemon alive on Github Actions

commit 6260ae4
Author: Adam Novak <interfect@gmail.com>
Date:   Thu Oct 27 22:10:53 2022 -0400

    Just ship without Sentry bits, who knows if it will work

commit 228f433
Author: Adam Novak <interfect@gmail.com>
Date:   Wed Oct 26 22:45:59 2022 -0400

    Change tag trigger

commit 76f653a
Author: Adam Novak <interfect@gmail.com>
Date:   Wed Oct 26 22:36:46 2022 -0400

    Make release workflow run on pushed tags instead

commit ad7b81b
Author: Adam Novak <interfect@gmail.com>
Date:   Wed Oct 26 22:28:40 2022 -0400

    Make logo in new format

commit e79843f
Author: Adam Novak <interfect@gmail.com>
Date:   Sat Oct 22 12:26:38 2022 -0400

    Add channel to Nimbus again somehow

commit c8aa81b
Author: Adam Novak <interfect@gmail.com>
Date:   Sat Oct 22 12:24:17 2022 -0400

    Make nimbus-fml work on forkRelease

commit 27eb3fd
Author: Adam Novak <interfect@gmail.com>
Date:   Sat Oct 22 12:08:21 2022 -0400

    Fiddle with Nimbus to try and get it to not break the build

commit 1ebeca1
Author: Adam Novak <interfect@gmail.com>
Date:   Wed Oct 19 09:56:31 2022 -0400

    Fix merge

commit 7dcbf8c
Author: Adam Novak <interfect@gmail.com>
Date:   Mon May 9 20:49:07 2022 -0400

    Do all of Iceraven in one commit

    Bump top site limit under its new name

    Fix unresilved conflict

    Allow Nimbus to generate code that allows the fork flavors

    Drop private browsing page again

    Use the new text color name

    Point at paged style again

    Bring back Sentry so we don't have to change the code that would call it

    Note we need to build with app: now for some reason

    Also prefix Github build commands

    Adapt to settings moving

    Parse Iceraven versions

    Discover the linter's formatter

    Get rid of some Detekt complaints

    Handle more weird version strings

    Finish README

    Stop auto-release changelogs from being too huge

    Fix #440 by reattaching settings

commit 71ca6c1
Author: MickeyMoz <sebastian@mozilla.com>
Date:   Mon Oct 10 23:30:24 2022 +0000

    Update to Android-Components 106.0.5.

commit 8226605
Author: Pascal Chevrel <pascal@mozilla.com>
Date:   Mon Oct 10 18:14:52 2022 +0200

     Bump version to 106.1.0

commit cd22c8c
Author: runner <runner@4f047dc51429>
Date:   Mon Oct 10 02:59:43 2022 +0000

    Strings - app/src/main/res/values-pa-rIN/strings.xml

commit 3731006
Author: runner <runner@4f047dc51429>
Date:   Mon Oct 10 02:59:43 2022 +0000

    Strings - app/src/main/res/values-ja/strings.xml

commit 1e7f69b
Author: runner <runner@26e53c9e94ff>
Date:   Sun Oct 9 02:58:38 2022 +0000

    Strings - app/src/main/res/values-rm/strings.xml

commit 95897a3
Author: runner <runner@26e53c9e94ff>
Date:   Sun Oct 9 02:58:38 2022 +0000

    Strings - app/src/main/res/values-pl/strings.xml

commit 9530952
Author: runner <runner@26e53c9e94ff>
Date:   Sun Oct 9 02:58:38 2022 +0000

    Strings - app/src/main/res/values-ja/strings.xml

commit a49b266
Author: runner <runner@26e53c9e94ff>
Date:   Sun Oct 9 02:58:38 2022 +0000

    Strings - app/src/main/res/values-eo/strings.xml

commit 6370741
Author: runner <runner@26e53c9e94ff>
Date:   Sun Oct 9 02:58:38 2022 +0000

    Strings - app/src/main/res/values-co/strings.xml

commit 0ac14e5
Author: runner <runner@0387bc9ed388>
Date:   Sat Oct 8 02:47:10 2022 +0000

    Strings - app/src/main/res/values-lo/strings.xml

commit 33b3b3c
Author: runner <runner@0387bc9ed388>
Date:   Sat Oct 8 02:47:10 2022 +0000

    Strings - app/src/main/res/values-ka/strings.xml

commit aa1d1ed
Author: runner <runner@0387bc9ed388>
Date:   Sat Oct 8 02:47:10 2022 +0000

    Strings - app/src/main/res/values-co/strings.xml

commit 8a71450
Author: Mozilla Releng Treescript <release+release-automation-bot@mozilla.com>
Date:   Fri Oct 7 04:06:33 2022 +0000

    Automatic version bump CLOSED TREE NO BUG a=release

commit acdaf02
Author: MickeyMoz <sebastian@mozilla.com>
Date:   Fri Oct 7 02:27:01 2022 +0000

    Update to Android-Components 106.0.4.

commit af45392
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 7 03:22:33 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27325)

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-su/strings.xml

    Co-authored-by: runner <runner@e8fe2187cfdc>

commit 2e3e5d9
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Oct 6 03:18:02 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27297)

    * Strings - app/src/main/res/values-da/strings.xml

    * Strings - app/src/main/res/values-fr/strings.xml

    * Strings - app/src/main/res/values-pt-rPT/strings.xml

    * Strings - app/src/main/res/values-sl/strings.xml

    Co-authored-by: runner <runner@e9838f49e0e0>

commit 180d730
Author: mike a <mavduevskiy@gmail.com>
Date:   Thu Sep 29 21:56:13 2022 -0700

    Closes mozilla-mobile#27209: fix WallpapersSettings crash

    (cherry picked from commit 595d931)

commit f64642e
Author: mergify <mergify@users.noreply.github.com>
Date:   Wed Oct 5 18:42:26 2022 +0000

    update initial_experiments.json based on the current first-run experiments in experimenter

    (cherry picked from commit 11af9ab)

commit 02c2b82
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 5 03:18:54 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27273)

    * Strings - app/src/main/res/values-dsb/strings.xml

    * Strings - app/src/main/res/values-in/strings.xml

    Co-authored-by: runner <runner@8b183d930c97>

commit cbb0cf3
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 4 03:18:48 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27261)

    * Strings - app/src/main/res/values-en-rCA/strings.xml

    * Strings - app/src/main/res/values-es/strings.xml

    * Strings - app/src/main/res/values-hsb/strings.xml

    * Strings - app/src/main/res/values-ja/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-nn-rNO/strings.xml

    * Strings - app/src/main/res/values-su/strings.xml

    Co-authored-by: runner <runner@aad477deb4ac>

commit fc22e8a
Author: Mozilla Releng Treescript <release+release-automation-bot@mozilla.com>
Date:   Mon Oct 3 18:55:21 2022 +0000

    Automatic version bump CLOSED TREE NO BUG a=release

commit 4560430
Author: MickeyMoz <sebastian@mozilla.com>
Date:   Mon Oct 3 17:27:03 2022 +0000

    Update to Android-Components 106.0.3.

commit b0b5548
Author: Mozilla Releng Treescript <release+release-automation-bot@mozilla.com>
Date:   Mon Oct 3 16:12:21 2022 +0000

    Automatic version bump CLOSED TREE NO BUG a=release

commit 17d6489
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Oct 3 03:14:30 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27250)

    * Strings - app/src/main/res/values-be/strings.xml

    * Strings - app/src/main/res/values-eo/strings.xml

    * Strings - app/src/main/res/values-es-rES/strings.xml

    * Strings - app/src/main/res/values-eu/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-oc/strings.xml

    * Strings - app/src/main/res/values-pt-rPT/strings.xml

    * Strings - app/src/main/res/values-su/strings.xml

    Co-authored-by: runner <runner@7a9a18a2e5a4>

commit 4f95c3a
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Oct 2 03:31:16 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27243)

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-su/strings.xml

    * Strings - app/src/main/res/values-th/strings.xml

    Co-authored-by: runner <runner@a4e6baf40f5d>

commit 69513fd
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Oct 1 03:32:10 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27236)

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-pt-rBR/strings.xml

    * Strings - app/src/main/res/values-su/strings.xml

    Co-authored-by: runner <runner@81574a6914e1>

commit da650d5
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 30 12:49:18 2022 -0700

    For mozilla-mobile#27127: do not display wallpaper onboarding in private browsing mode (mozilla-mobile#27232)

    (cherry picked from commit 521f148)

    Co-authored-by: MatthewTighe <mtighe@mozilla.com>

commit 92f76ff
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Sep 30 03:27:22 2022 +0000

    Strings - app/src/main/res/values-lo/strings.xml (mozilla-mobile#27227)

    Co-authored-by: runner <runner@ff3eff094a84>

commit e803241
Author: Jonathan Almeida <jalmeida@mozilla.com>
Date:   Thu Sep 22 07:37:35 2022 -0400

    Closes mozilla-mobile#27077: Load first run experiments synchronously.

    Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
    Co-authored-by: Charlie Humphreys <chumphreys@mozilla.com>
    Co-authored-by: jhugman <jhugman@users.noreply.github.com>
    (cherry picked from commit 911f350)

commit 2e044bc
Author: MickeyMoz <sebastian@mozilla.com>
Date:   Fri Sep 30 01:24:20 2022 +0000

    Update to Android-Components 106.0.2.

commit db76538
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Sep 29 03:30:58 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27213)

    * Strings - app/src/main/res/values-be/strings.xml

    * Strings - app/src/main/res/values-br/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    Co-authored-by: runner <runner@7661f04723e7>

commit 3e625b9
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Sep 28 12:34:22 2022 -0700

    For mozilla-mobile#26644 - Apply the new theme earlier to the private browsing button (mozilla-mobile#27204)

    This will help avoid a race between the two layers of the svg, with previously
    only changing the color for just one.
    By applying the new theme to the button when needing to apply the textColor
    from wallpaper it will automatically use the right

    (cherry picked from commit c7c5682)

    Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>

commit d8bd4c8
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Wed Sep 28 12:29:57 2022 -0700

    For mozilla-mobile#26424 - Handle special legacy wallpaper cases (mozilla-mobile#27203)

    (cherry picked from commit 1968517)

    Co-authored-by: Alexandru2909 <aputanu@mozilla.com>

commit 2d78c2a
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 28 03:31:37 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27202)

    * Strings - app/src/main/res/values-ast/strings.xml

    * Strings - app/src/main/res/values-kab/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-oc/strings.xml

    * Strings - app/src/main/res/values-pt-rPT/strings.xml

    Co-authored-by: runner <runner@a4eb10f394df>

commit 20924ce
Author: Gabriel Luong <gabriel.luong@gmail.com>
Date:   Thu Sep 15 17:10:50 2022 -0400

    For mozilla-mobile#27026 - Use the wallpaper adapted text color for the Collections placeholder

    (cherry picked from commit 444f663)

commit 7bfe1ad
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Tue Sep 27 15:11:14 2022 -0700

    For mozilla-mobile#26644 - Apply the wallpaper provided text color to the Fenix logo (backport mozilla-mobile#27009) (mozilla-mobile#27196)

    * For mozilla-mobile#26644 - Split the Fenix logo in two images

    This will allow us applying a certain tint just for the image containing a text
    to have a better contrast with wallpapers.

    (cherry picked from commit 103a0cb)

    * For mozilla-mobile#26644 - Apply the wallpaper provided text color to the Fenix logo

    And to the private mode switcher.

    (cherry picked from commit 7b5ba84)

    Co-authored-by: Mugurell <Mugurell@users.noreply.github.com>

commit b971a4c
Author: Mugurell <Mugurell@users.noreply.github.com>
Date:   Tue Sep 27 10:08:13 2022 +0300

    For mozilla-mobile#27172 - Enable the home onboarding dialog in all releases

    (cherry picked from commit 460008c)

commit 199fa8e
Author: Mugurell <Mugurell@users.noreply.github.com>
Date:   Tue Sep 27 10:07:25 2022 +0300

    For mozilla-mobile#27172 - Enable the sync onboarding cfr in all releases

    (cherry picked from commit c3a3cae)

commit 57568b1
Author: Mugurell <Mugurell@users.noreply.github.com>
Date:   Tue Sep 27 16:23:07 2022 +0300

    For mozilla-mobile#27111 - Disable TCP by default in 106.

    Nimbus will still be able to enable it if needed.

commit 2d23acf
Author: Mugurell <Mugurell@users.noreply.github.com>
Date:   Tue Sep 27 12:57:14 2022 +0300

    For mozilla-mobile#27111 - Allow TCP in all releases. Control it from Nimbus.

    After this change the TCP feature (and CFR) are enabled by default.
    Rollout can be controlled through Nimbus.

    (cherry picked from commit 6c2609a)

commit e3b7b2b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Sep 27 03:29:27 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27187)

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-pa-rIN/strings.xml

    * Strings - app/src/main/res/values-zh-rTW/strings.xml

    Co-authored-by: runner <runner@7dde538f30c3>

commit f8690be
Author: MatthewTighe <mtighe@mozilla.com>
Date:   Fri Sep 23 15:45:46 2022 -0700

    For mozilla-mobile#27111: disable TCP in beta and release

    (cherry picked from commit 5c9a713)

commit fbd956c
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Sep 26 03:57:19 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27166)

    * Strings - app/src/main/res/values-kk/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-ru/strings.xml

    * Strings - app/src/main/res/values-sk/strings.xml

    Co-authored-by: runner <runner@1466d2cffcbe>

commit ce63a8f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Sep 25 03:29:34 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27158)

    * Strings - app/src/main/res/values-kk/strings.xml

    * Strings - app/src/main/res/values-kmr/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-sl/strings.xml

    * Strings - app/src/main/res/values-th/strings.xml

    Co-authored-by: runner <runner@c88984fd1e80>

commit 1686851
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Sep 24 03:29:08 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27151)

    * Strings - app/src/main/res/values-es-rCL/strings.xml

    * Strings - app/src/main/res/values-fr/strings.xml

    * Strings - app/src/main/res/values-iw/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-zh-rCN/strings.xml

    Co-authored-by: runner <runner@219c0361b766>

commit fc7b2ed
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 23 16:53:32 2022 -0700

    For mozilla-mobile#27055: handle legacy wallpaper naming case (mozilla-mobile#27140)

    (cherry picked from commit 5811b06)

    Co-authored-by: MatthewTighe <mtighe@mozilla.com>

commit f326c01
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 23 16:53:22 2022 -0700

    Closes mozilla-mobile#26966: enable wallpapers V2 (mozilla-mobile#27141)

    (cherry picked from commit 6f24fad)

    Co-authored-by: MatthewTighe <mtighe@mozilla.com>
    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

commit 0207dac
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Fri Sep 23 18:49:23 2022 -0400

    Closes mozilla-mobile#27081: enable wallpaper onboarding flag (mozilla-mobile#27142)

    (cherry picked from commit ace7b1e)

    Co-authored-by: MatthewTighe <mtighe@mozilla.com>

commit b02fe09
Author: Mozilla Releng Treescript <release+release-automation-bot@mozilla.com>
Date:   Fri Sep 23 11:59:09 2022 +0000

    Automatic version bump CLOSED TREE NO BUG a=release

commit 9b05230
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Sep 23 03:32:37 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27118)

    * Strings - app/src/main/res/values-es-rMX/strings.xml

    * Strings - app/src/main/res/values-fi/strings.xml

    * Strings - app/src/main/res/values-gn/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-nb-rNO/strings.xml

    * Strings - app/src/main/res/values-su/strings.xml

    * Strings - app/src/main/res/values-tr/strings.xml

    Co-authored-by: runner <runner@8450fe7ac230>

commit d5b55f2
Author: jeddai <jeddai@users.noreply.github.com>
Date:   Thu Sep 22 16:30:33 2022 +0000

    update initial_experiments.json based on the current first-run experiments in experimenter

    (cherry picked from commit fba4651)

commit bedd4b5
Author: MickeyMoz <sebastian@mozilla.com>
Date:   Thu Sep 22 12:23:37 2022 +0000

    Update to Android-Components 106.0.1.

commit abbc481
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Sep 22 03:24:12 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27100)

    * Strings - app/src/main/res/values-el/strings.xml

    * Strings - app/src/main/res/values-fi/strings.xml

    * Strings - app/src/main/res/values-fr/strings.xml

    * Strings - app/src/main/res/values-it/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-sl/strings.xml

    * Strings - app/src/main/res/values-te/strings.xml

    * Strings - app/src/main/res/values-tr/strings.xml

    Co-authored-by: runner <runner@1c2f0c103f22>

commit a86bf25
Author: MatthewTighe <mtighe@mozilla.com>
Date:   Tue Sep 20 11:39:07 2022 -0700

    For mozilla-mobile#27055: check whether applied wallpaper name is blank

    (cherry picked from commit 414c569)

commit 73c4f78
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Sep 21 03:39:08 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27084)

    * Strings - app/src/main/res/values-cy/strings.xml

    * Strings - app/src/main/res/values-el/strings.xml

    * Strings - app/src/main/res/values-en-rGB/strings.xml

    * Strings - app/src/main/res/values-es-rAR/strings.xml

    * Strings - app/src/main/res/values-es-rMX/strings.xml

    * Strings - app/src/main/res/values-fi/strings.xml

    * Strings - app/src/main/res/values-fy-rNL/strings.xml

    * Strings - app/src/main/res/values-gn/strings.xml

    * Strings - app/src/main/res/values-hu/strings.xml

    * Strings - app/src/main/res/values-hy-rAM/strings.xml

    * Strings - app/src/main/res/values-ia/strings.xml

    * Strings - app/src/main/res/values-is/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-nl/strings.xml

    * Strings - app/src/main/res/values-oc/strings.xml

    * Strings - app/src/main/res/values-sl/strings.xml

    * Strings - app/src/main/res/values-sv-rSE/strings.xml

    * Strings - app/src/main/res/values-tg/strings.xml

    * Strings - app/src/main/res/values-uk/strings.xml

    * Strings - app/src/main/res/values-vi/strings.xml

    * Strings - app/src/main/res/values-zh-rCN/strings.xml

    * Strings - app/src/main/res/values-zh-rTW/strings.xml

    Co-authored-by: runner <runner@aa051b880b49>

commit d56179f
Author: Mozilla Releng Treescript <release+release-automation-bot@mozilla.com>
Date:   Tue Sep 20 14:20:55 2022 +0000

    Automatic version bump CLOSED TREE NO BUG a=release

commit 64ebd17
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Sep 20 03:28:21 2022 +0000

    Sync Strings from main to releases_106.0 (mozilla-mobile#27070)

    * Strings - app/src/main/res/values-be/strings.xml

    * Strings - app/src/main/res/values-de/strings.xml

    * Strings - app/src/main/res/values-dsb/strings.xml

    * Strings - app/src/main/res/values-el/strings.xml

    * Strings - app/src/main/res/values-iw/strings.xml

    * Strings - app/src/main/res/values-hsb/strings.xml

    * Strings - app/src/main/res/values-ia/strings.xml

    * Strings - app/src/main/res/values-ko/strings.xml

    * Strings - app/src/main/res/values-lo/strings.xml

    * Strings - app/src/main/res/values-pt-rBR/strings.xml

    * Strings - app/src/main/res/values-sk/strings.xml

    Co-authored-by: runner <runner@47e61aafec6a>

commit 61dc1e2
Author: MatthewTighe <mtighe@mozilla.com>
Date:   Thu Sep 15 09:51:43 2022 -0700

    Closes mozilla-mobile#26997: convert v1 wallpapers into collection group

    (cherry picked from commit c6af07d)

commit 74e6ce8
Author: Pascal Chevrel <pascal.chevrel@free.fr>
Date:   Mon Sep 19 13:32:50 2022 +0200

    Set Android-Components version to 106.0.0
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
…images

This will allow us applying a certain tint just for the image containing a text
to have a better contrast with wallpapers.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
… text color to the Fenix logo

And to the private mode switcher.
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
…to the private browsing button

This will help avoid a race between the two layers of the svg, with previously
only changing the color for just one.
By applying the new theme to the button when needing to apply the textColor
from wallpaper it will automatically use the right
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
…enix#26644 - Apply the new theme earlier to the private browsing button"

This reverts commit dbcd3fa given that the
severity of the new issue is much higher.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.