Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] "Double tap to link" Talkback readout in private mode #27252

Closed
Mugurell opened this issue Oct 3, 2022 · 7 comments · Fixed by #27682, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. eng:qa:verified QA Verified eng:ready Ready for engineering needs:triage Issue needs triage ux:replied tag to track needs-ux issues that have been responded to.
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Oct 3, 2022

STRs:

  • Have Talkback enabled
  • Enter private mode
  • Focus "Common myths about private browsing"

Actual:

  • Talkback reads "Common myths about private browsing. Double tap to link".

Expected:

  • UX input needed.

The action here is not "link" but maybe "open link to learn more" / "open documentation"?

DoubleTapToLink.mov

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added the Needs-UX Issues or tickets that need UX input or review label Oct 3, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 3, 2022
@mcarare
Copy link
Contributor

mcarare commented Oct 4, 2022

The text used for describing the action was previously used as defining the role, not the action, so I would say, currently, this is incorrectly used.

@mcarare mcarare added the access Accessibility: Talkback, HW keyboard/mouse, braile display etc. label Oct 4, 2022
@ewachowiak
Copy link

@Mugurell I'm not super familiar with Talkback so I have a few questions.

  • It appears to me that "Common myths about private browsing" IS a link. It is a link to a support article. My hypothesis is that the word "open" was left out of the talkback text on accident.
  • Is it standard for Talkback to read the name of the link first before describing the available action to open it? I would assume the user would need to know that the text was a link before reading it. For example "Link: Common myths about private browsing. Double tap to open link."
  • If the above is not true, I recommend updating the text to "Double tap to read the article."

@Mugurell
Copy link
Contributor Author

Mugurell commented Oct 25, 2022

@Mugurell I'm not super familiar with Talkback so I have a few questions.
Is it standard for Talkback to read the name of the link first before describing the available action to open it? I would assume the user would need to know that the text was a link before reading it. For example "Link: Common myths about private browsing. Double tap to open link."

The standard is for TalkBack to read the content description and then the role of the widget.
Here the initial readout was: "Common myths about private browsing, link. Double-tap to activate"
Seems like Jetpack Compose doesn't yet support a "Link" role - https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt;l=558-597 so we'll have to do without it.

If the above is not true, I recommend updating the text to "Double tap to read the article."

"Common myths about private browsing. Double-tap to read the article" is doable, thank you!

@Mugurell Mugurell added eng:ready Ready for engineering and removed Needs-UX Issues or tickets that need UX input or review labels Oct 25, 2022
@ewachowiak
Copy link

Thanks @Mugurell. That sounds good to me!

@lime124 lime124 assigned lime124 and kbrosnan and unassigned lime124 Oct 25, 2022
@lime124
Copy link
Collaborator

lime124 commented Oct 25, 2022

@kbrosnan FYI this is really to be pulled into a sprint to fix. Thanks!

Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Nov 3, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 3, 2022
@mergify mergify bot closed this as completed in #27682 Nov 4, 2022
@github-actions github-actions bot added this to the 108 milestone Nov 4, 2022
@github-actions github-actions bot reopened this Nov 4, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 4, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed in the latest Nightly 108.0a1 (2022-11-07).
Talkback now reads: "Common myths about private browsing. Double-tap to read the article"
Device used: Oppo Find X5 (Android 12).
Closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 7, 2022
@lime124 lime124 added the ux:replied tag to track needs-ux issues that have been responded to. label Nov 10, 2022
@SoftVision-LorandJanos
Copy link

Verified on the latest Beta 108.0b1.
Device used: Google Pixel 4 (Android 13).

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. eng:qa:verified QA Verified eng:ready Ready for engineering needs:triage Issue needs triage ux:replied tag to track needs-ux issues that have been responded to.
Projects
None yet
6 participants