Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove WallpaperManager #27282

Closed
MatthewTighe opened this issue Oct 5, 2022 · 2 comments · Fixed by #27413 or nathanmkaya/fenix#108
Closed

Remove WallpaperManager #27282

MatthewTighe opened this issue Oct 5, 2022 · 2 comments · Fixed by #27413 or nathanmkaya/fenix#108
Labels
Feature:Wallpapers good first issue Good for newcomers
Milestone
108

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Oct 5, 2022 •
edited by data-sync-user

WallpaperManager is a leftover piece of tech debt from Wallpapers v1. It is time to remove it entirely.

It looks like the only usage of the class is through WallpaperManager.isDefaultTheCurrentWallpaper, which can be moved and/or reworked into the companion of Wallpaper.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 5, 2022
@MatthewTighe MatthewTighe removed the needs:triage Issue needs triage label Oct 5, 2022
@mbaimuratov
Copy link
Contributor

Can I work on this?

mbaimuratov added a commit to mbaimuratov/fenix that referenced this issue Oct 12, 2022
@mbaimuratov
For mozilla-mobile#27282: remove WallpaperManager from Components.kt
8843cc5
mbaimuratov added a commit to mbaimuratov/fenix that referenced this issue Oct 12, 2022
@mbaimuratov
For mozilla-mobile#27282: remove WallpaperManager from FenixApplicati…
7802fea 
…on.kt
mbaimuratov added a commit to mbaimuratov/fenix that referenced this issue Oct 12, 2022
@mbaimuratov
For mozilla-mobile#27282: delete WallpaperManager and WallpaperManage…
44dd75b 
…rTest.kt
@github-actions github-actions bot mentioned this issue Oct 12, 2022
Closed
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 12, 2022
@MatthewTighe
Copy link
Contributor Author

Definitely! Thanks for your contribution 🙂

@MatthewTighe MatthewTighe mentioned this issue Oct 12, 2022
Closed
mbaimuratov added a commit to mbaimuratov/fenix that referenced this issue Oct 13, 2022
@mbaimuratov
For mozilla-mobile#27282: delete WallpaperManager
522dfc7
mbaimuratov added a commit to mbaimuratov/fenix that referenced this issue Oct 13, 2022
@mbaimuratov
For mozilla-mobile#27282: delete WallpaperManager
a446687
@github-actions github-actions bot mentioned this issue Oct 14, 2022
Merged
4 tasks
MatthewTighe pushed a commit to MatthewTighe/fenix that referenced this issue Oct 14, 2022
@mbaimuratov @MatthewTighe
For mozilla-mobile#27282: delete WallpaperManager
3644e6b
MatthewTighe pushed a commit to MatthewTighe/fenix that referenced this issue Oct 19, 2022
@mbaimuratov @MatthewTighe
For mozilla-mobile#27282: delete WallpaperManager
7e42b67
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 19, 2022
@mergify mergify bot closed this as completed in #27413 Oct 20, 2022
mergify bot pushed a commit that referenced this issue Oct 20, 2022
@mbaimuratov @mergify
For #27282: delete WallpaperManager
adfed99
@github-actions github-actions bot added this to the 108 milestone Oct 20, 2022
@github-actions github-actions bot mentioned this issue Nov 17, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@mbaimuratov @mergify
[fenix] For mozilla-mobilehttps://github.com/mozilla-mobile/fenix/iss…
d1aac8d 
…ues/27282: delete WallpaperManager
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature:Wallpapers good first issue Good for newcomers
Projects
None yet
Milestone
108
2 participants
@MatthewTighe @mbaimuratov