Refactor DefaultLoadBitmapUseCase to receive orientation as argument

[MatthewTighe]

The WallpaperUseCases.DefaultLoadBitmapUseCase currently accepts a Context as an argument. It then determines the current device orientation inline in order to load the correct (landscape/portrait) bitmap for a wallpaper.

By removing the Context parameter and replacing it with the orientation, the function should be more testable and maintainable. It is also the only Context-dependent part of the updated Use Cases and is a copied holdover from the legacy versions, so it will mean we should be able to completely remove Context from WallpaperUseCases after #26968

┆Issue is synchronized with this Jira Task

[mbaimuratov]

Will be happy to contribute here!

One question:

I guess I also need to provide filesDir as a param, since we are getting it from context too:
val file = File(context.filesDir, path)
right?

[MatthewTighe]

Great, thanks for helping out!

I guess I also need to provide filesDir as a param, since we are getting it from context too:
val file = File(context.filesDir, path)
right?

That's correct. The filesDir is already available to the top-level WallpaperUseCases, so it should just be a matter of passing it down.

[mbaimuratov]

Great, thanks for helping out!

I guess I also need to provide filesDir as a param, since we are getting it from context too:
val file = File(context.filesDir, path)
right?

That's correct. The filesDir is already available to the top-level WallpaperUseCases, so it should just be a matter of passing it down.

Then, I guess, I could contribute here :)

[oyeraghib]

@mbaimuratov are you still working on with this ?

[PrashantSaroj]

Hey @MatthewTighe, I would like to work on this issue. I have created this PR #27730 . How do I test if my changes are correct?