Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Combine Google package name regex into a single one #27336

Closed
jonalmeida opened this issue Oct 8, 2022 · 3 comments · Fixed by #27444, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Closed
Labels
eng:build Build system, gradle, configuration good first issue Good for newcomers
Milestone

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Oct 8, 2022

When comGoogleAndroid and comGoogleFirebase was originally added (commit), I don't think it was possible (or at least easy) to generalize because comGoogleAndroid explicitly excluded some com.google.android.* deps that hadn't yet migrated from maven central to the google repo, i.e. it was defined as:

    const val comGoogleAndroid = "com\\.google\\.android\\.(?!apps\\.common\\.testing\\.accessibility\\.framework).*"

Now that it's defined more generically (i.e. Google is hosting more packages on their repo), it might be possible. In that case, it'd also be preferable to reduce duplication (like the root cause of this issue).

Originally posted by @mcomella in #27321 (comment)

  1. We want to take the comGoogleFirebase, comGoogleTesting, and comGoogleAndroid defined here to be combined into a single comGoogle with the value: com\\.google\\..*.
  2. We also need to update all the previous references to use just this one.
  3. Remove this comment as well.

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added good first issue Good for newcomers eng:build Build system, gradle, configuration labels Oct 8, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 8, 2022
@chetanmuliya
Copy link
Contributor

can I fix this?

@jonalmeida
Copy link
Contributor Author

Sure!

@chetanmuliya
Copy link
Contributor

thanks

@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 18, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Oct 18, 2022
chetanmuliya added a commit to chetanmuliya/fenix that referenced this issue Oct 21, 2022
jonalmeida pushed a commit to chetanmuliya/fenix that referenced this issue Oct 26, 2022
chetanmuliya added a commit to chetanmuliya/fenix that referenced this issue Oct 27, 2022
jonalmeida pushed a commit to jonalmeida/fenix that referenced this issue Oct 27, 2022
@mergify mergify bot closed this as completed in #27444 Oct 27, 2022
@github-actions github-actions bot reopened this Oct 27, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Oct 27, 2022
@github-actions github-actions bot added this to the 108 milestone Oct 27, 2022
@jonalmeida jonalmeida removed the eng:qa:needed QA Needed label Oct 27, 2022
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:build Build system, gradle, configuration good first issue Good for newcomers
Projects
None yet
3 participants