This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Refactor SelectableChip
to be a top level Chip
component
#27401
Labels
Milestone
Comments
4 tasks
30 tasks
Okay yea, the contract totally makes sense to me. Thanks for the thorough issue description. |
This was referenced Oct 18, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Oct 28, 2022
4 tasks
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Oct 28, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Nov 1, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 1, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 6, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 6, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 6, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 8, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 8, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 12, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 12, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 13, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 13, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 14, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 14, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 15, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 19, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 17, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 17, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 17, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 18, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 19, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 19, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 19, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 19, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 19, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 19, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 23, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 23, 2023
…tableChipColors
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 24, 2023
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 24, 2023
…tableChipColors
JohanLorenzo
pushed a commit
to mozilla-releng/staging-firefox-android
that referenced
this issue
Jan 25, 2023
… Chip composable
JohanLorenzo
pushed a commit
to mozilla-releng/staging-firefox-android
that referenced
this issue
Jan 25, 2023
…ies with SelectableChipColors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
SelectableChip
Composable is effectively aChip
that just handles re-colors based on theisSelected
boolean. The component would be best served as a genericChip
component (similar toTextButton
) that has a condensed list of parameters and uplifts any stateful logic (such as selected vs unselected) to the actual UI that uses it.The contract should be something like:
The other Chip component use cases (such as having an optional icon) could be implemented as well.
The text & default colors should be double checked against their specs in FIgma.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: