Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Make a top-level Divider Composable component #27459

Closed
2 tasks
Tracked by #24339
MozillaNoah opened this issue Oct 18, 2022 · 0 comments · Fixed by #27544, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Closed
2 tasks
Tracked by #24339

Make a top-level Divider Composable component #27459

MozillaNoah opened this issue Oct 18, 2022 · 0 comments · Fixed by #27544, Leland-Takamine/fenix#159, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
@HarrisonOg
Labels
compose Tickets involving Composable changes eng:health Improve code health

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Oct 18, 2022 •
edited

Currently, we implement a Compose library Divider() composable when adding a line to separate visual elements. To streamline this, we should have a Divider and composable which incorporates our styles and makes the declaration of dividers a single line with optional modifiers.

Todo

  • Top level Divider with our style applied (figma below)
  • Any/all applicable previews

Figma

┆Issue is synchronized with this Jira Task
@MozillaNoah MozillaNoah added eng:health Improve code health compose Tickets involving Composable changes labels Oct 18, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 18, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Oct 18, 2022
@MozillaNoah MozillaNoah mentioned this issue Oct 18, 2022
Closed
30 tasks
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 25, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
1d45ed2
@github-actions github-actions bot mentioned this issue Oct 25, 2022
Merged
4 tasks
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 26, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
2c6b87c
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 26, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
d65e9dc
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 26, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
1a0684d
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 26, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
c34415a
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 27, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
8d26b2c
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 27, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
e1d544f
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 27, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
2459fef
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 28, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
9037999
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 28, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
6e41634
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 31, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
395059f
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Oct 31, 2022
@HarrisonOg
For mozilla-mobile#27459 - Add divider composable
f039cc6
HarrisonOg added a commit that referenced this issue Oct 31, 2022
@HarrisonOg
For #27459 - Add divider composable (#27544)
e052493
This was referenced Oct 31, 2022
Merged
Merged
@github-actions github-actions bot mentioned this issue Nov 29, 2022
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@HarrisonOg
[fenix] For mozilla-mobile/fenix#27459 - Add divider composable (mozi…
835ba7a 
…lla-mobile/fenix#27544)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarrisonOg HarrisonOg

Labels
compose Tickets involving Composable changes eng:health Improve code health
Projects
None yet
Milestone
No milestone
2 participants
@HarrisonOg @MozillaNoah