Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #27459 - Add divider composable #27544

Conversation

HarrisonOg
Copy link
Contributor

@HarrisonOg HarrisonOg commented Oct 25, 2022

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27459

@HarrisonOg HarrisonOg force-pushed the harrison/widget/compose-divider-widget branch 3 times, most recently from d65e9dc to 1a0684d Compare October 26, 2022 21:05
@HarrisonOg HarrisonOg marked this pull request as ready for review October 26, 2022 21:05
@HarrisonOg HarrisonOg requested review from a team as code owners October 26, 2022 21:05
@HarrisonOg HarrisonOg force-pushed the harrison/widget/compose-divider-widget branch from be590f3 to c34415a Compare October 26, 2022 22:57
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Oct 27, 2022
@HarrisonOg HarrisonOg force-pushed the harrison/widget/compose-divider-widget branch 6 times, most recently from 6e41634 to 395059f Compare October 31, 2022 16:10
@HarrisonOg
Copy link
Contributor Author

once all the checks are good (I just rebased onto main again) I'll merge this one in @gabrielluong

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a top-level Divider Composable component
2 participants