Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add tab cards to share sheet #2754

Closed
jonalmeida opened this issue May 22, 2019 · 8 comments
Closed

Add tab cards to share sheet #2754

jonalmeida opened this issue May 22, 2019 · 8 comments
Assignees
@colintheshots
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:SendTab Feature:Sharing needs:sumo Mozilla Suport - suport.mozilla.org
Projects
Fenix Q3 Feature Backlog Fennec to Fenix Transition
Milestone
v2.2

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented May 22, 2019 •
edited by data-sync-user
Loading

Parent: #331

The card on the top of the share sheet that shows the tab(s) being sent. On the right is what the share sheet currently looks like.

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added the eng:task An engineering breakout issue of a user story label May 22, 2019
@jonalmeida jonalmeida self-assigned this May 22, 2019
@jonalmeida jonalmeida mentioned this issue May 22, 2019
Merged
4 tasks
@jonalmeida
Copy link
Contributor Author

Spoke with Nicole and Vesta offline, we're going to going to use the same styling of collections for the tab list.

@vrudesai vrudesai added this to the Post-MVP Backlog milestone May 28, 2019
@jonalmeida jonalmeida removed their assignment May 28, 2019
@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Jul 16, 2019
@vesta0 vesta0 moved this from To be Triaged to Prioritized Backlog in Fenix Sprint Kanban Jul 17, 2019
@vesta0 vesta0 added the P2 Upcoming release label Jul 17, 2019
@vesta0 vesta0 removed this from the 1.1 Backlog milestone Jul 24, 2019
@vesta0 vesta0 mentioned this issue Jul 24, 2019
Closed
6 tasks
@vesta0 vesta0 removed this from Prioritized Feature Backlog in Fenix Sprint Kanban Jul 24, 2019
@vesta0 vesta0 added this to To be Triaged in Fenix Sprint Kanban via automation Aug 2, 2019
@vesta0 vesta0 added must and removed P2 Upcoming release labels Aug 2, 2019
@vesta0 vesta0 moved this from To be Triaged to Prioritized Feature Backlog in Fenix Sprint Kanban Aug 2, 2019
@vesta0 vesta0 removed the eng:task An engineering breakout issue of a user story label Aug 7, 2019
@vesta0 vesta0 changed the title [Share] Add tab cards to share sheet Add tab cards to share sheet Aug 7, 2019
@bifleming bifleming added this to Prioritized Backlog in Fennec to Fenix Transition Aug 14, 2019
@vesta0 vesta0 added the E5 Estimation Point: about 5 days label Aug 23, 2019
@sblatz sblatz moved this from Prioritized Feature Backlog to Sprint Backlog in Fenix Sprint Kanban Aug 30, 2019
@topotropic topotropic removed their assignment Sep 17, 2019
@topotropic topotropic moved this from In Design to Prioritized Eng Backlog in Fenix Sprint Kanban Sep 17, 2019
@topotropic topotropic moved this from Prioritized Eng Backlog to Sprint Backlog in Fenix Sprint Kanban Sep 17, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 19, 2019

@colintheshots are you planning on picking this up? :)

@sblatz sblatz moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban Sep 20, 2019
@colintheshots
Copy link
Contributor

I'm still on this. I have most of it implemented. I'm adding the finishing touches.

colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 23, 2019
@colintheshots
For mozilla-mobile#2754 Add tab cards to share sheet
ecc8f5e
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 23, 2019
@colintheshots
For mozilla-mobile#2754 Add tab cards to share sheet
184c68f
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 24, 2019
@colintheshots
For mozilla-mobile#2754 Add tab cards to share sheet
613e649
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 24, 2019
@colintheshots
For mozilla-mobile#2754: Fix background near rounded corners and Shar…
d0e09c3 
…eButtonAppearanceTest
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 25, 2019
@colintheshots
For mozilla-mobile#2754 Add tab cards to share sheet
8b7f2de
colintheshots added a commit to colintheshots/fenix that referenced this issue Sep 25, 2019
@colintheshots
For mozilla-mobile#2754: Fix background near rounded corners and Shar…
652c349 
…eButtonAppearanceTest
sblatz pushed a commit that referenced this issue Sep 26, 2019
@colintheshots @sblatz
For #2754 Add tab cards to share sheet (#5493)
de93b05 
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
@sblatz sblatz added the eng:qa:needed QA Needed label Sep 26, 2019
@sblatz sblatz added this to the v2.2 milestone Sep 26, 2019
@sblatz sblatz moved this from In Progress to Ready for QA in Fenix Sprint Kanban Sep 26, 2019
@abodea
Copy link
Member

abodea commented Sep 27, 2019

Verified as fixed on the latest Nightly 190927 (#12700627) using Samsung Galaxy s10+(A9), Google Pixel 3a XL(A9).
Note that the behavior is the one presented in this comment.

@abodea abodea closed this as completed Sep 27, 2019
Fenix Sprint Kanban automation moved this from Ready for QA to Done Sep 27, 2019
Fenix Q3 Feature Backlog automation moved this from Must to Done! Sep 27, 2019
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 27, 2019
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
@colintheshots @sblatz
For mozilla-mobile#2754 Add tab cards to share sheet (mozilla-mobile#…
d6697cc 
…5493)

* For mozilla-mobile#2754 Add tab cards to share sheet

* For mozilla-mobile#2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
sblatz pushed a commit to sblatz/fenix that referenced this issue Sep 30, 2019
@colintheshots @sblatz
For mozilla-mobile#2754 Add tab cards to share sheet (mozilla-mobile#…
7259aa2 
…5493)

* For mozilla-mobile#2754 Add tab cards to share sheet

* For mozilla-mobile#2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
@NotWoods NotWoods mentioned this issue Nov 19, 2019
Merged
5 tasks
@data-sync-user data-sync-user changed the title Add tab cards to share sheet FNX2-18252 ⁃ Add tab cards to share sheet Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18252 ⁃ Add tab cards to share sheet FNX3-16557 ⁃ Add tab cards to share sheet Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16557 ⁃ Add tab cards to share sheet Add tab cards to share sheet May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@colintheshots colintheshots

Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:SendTab Feature:Sharing needs:sumo Mozilla Suport - suport.mozilla.org
Projects
No open projects
Fenix Q3 Feature Backlog
  
Done!
Fennec to Fenix Transition
Backlog
Milestone
v2.2
Development

No branches or pull requests
10 participants
@topotropic @colintheshots @liuche @jonalmeida @NotWoods @sblatz @vesta0 @abodea @vrudesai @data-sync-user