For #2754 Add tab cards to share sheet

[colintheshots]

This is using the new UX, not the old version at the top of the ticket.

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[codecov-io]

Codecov Report

Merging #5493 into master will decrease coverage by 0.03%.
The diff coverage is 5.4%.

@@             Coverage Diff              @@
##             master    #5493      +/-   ##
============================================
- Coverage     14.04%   14.01%   -0.04%     
  Complexity      311      311              
============================================
  Files           255      256       +1     
  Lines         10414    10445      +31     
  Branches       1507     1509       +2     
============================================
+ Hits           1463     1464       +1     
- Misses         8840     8870      +30     
  Partials        111      111

Impacted Files	Coverage Δ	Complexity Δ
...main/java/org/mozilla/fenix/share/ShareFragment.kt	1.06% <0%> (-0.05%)	0 <0> (ø)
...zilla/fenix/share/listadapters/ShareTabsAdapter.kt	0% <0%> (ø)	0 <0> (?)
...ain/java/org/mozilla/fenix/share/ShareCloseView.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...g/mozilla/fenix/library/history/HistoryFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...illa/fenix/library/bookmarks/BookmarkController.kt	100% <100%> (ø)	0 <0> (ø)	⬇️
...va/org/mozilla/fenix/onboarding/FenixOnboarding.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9c531...d6db5eb. Read the comment docs.

[sblatz]

@colintheshots Looks like this is failing on the ShareButtonAppearanceTest UI test.

[boek]

PR has updated strings, wait until we cut the release branch to land.

[boek]

Looks good! Just needs a missing license

[boek]

nit: license

[ekager]

In the first screenshot you posted it looks like there's a white sliver of background now on the corner of the share sheet? Could you take a look and fix that if it's a visual regression?

[colintheshots]

@ekager There's no more white sliver now.
@sblatz The test is now fixed.
@boek This can wait to land then.
Thanks!

[sblatz]

@colintheshots I believe you'll need to rebase master into this since we fixed a bad UI test that got merged into master.

[colintheshots]

@ekager This needs re-review. The white next to the corners showing through has been fixed.

Concern has been fixed