Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Collect shim information about sponsored stories interactions #27549

Closed
Mugurell opened this issue Oct 26, 2022 · 2 comments · Fixed by #27550, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Closed

Collect shim information about sponsored stories interactions #27549

Mugurell opened this issue Oct 26, 2022 · 2 comments · Fixed by #27550, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Assignees
@Mugurell
Labels
Feature:PocketIntegration Feature:Telemetry needs:triage Issue needs triage
Milestone
108

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Oct 26, 2022 •
edited
Loading

As a followup to the Pocket sponsored stories feature and the telemetry ticket - #25401 we need to collect the shim parameter of each story the user interacts with, both when the story is shown and clicked.

Based on the discussions with @Dexterp37 on https://mozilla-hub.atlassian.net/browse/FNXV2-21791 for this we should:

  • add a new custom ping
  • create new metrics of type text in which to send the shim.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Oct 26, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 26, 2022
@Dexterp37
Copy link
Contributor

Dexterp37 commented Oct 26, 2022 •
edited
Loading

@Mugurell it should be a text type, not a string type, to not hit the string limit :)

Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 26, 2022
@Mugurell
For mozilla-mobile#27549 - Collect shim data about the Pocket sponsor…
bec8b27 
…ed stories.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 26, 2022
@github-actions github-actions bot mentioned this issue Oct 26, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 27, 2022
@Mugurell
For mozilla-mobile#27549 - Collect shim data about the Pocket sponsor…
7f4c734 
…ed stories.
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 27, 2022
@Mugurell
For mozilla-mobile#27549 - Collect shim data about the Pocket sponsor…
a12a8a1 
…ed stories.
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 28, 2022
@Mugurell
For mozilla-mobile#27549 - Collect shim data about the Pocket sponsor…
18d6e24 
…ed stories.
Mugurell added a commit to Mugurell/fenix that referenced this issue Oct 28, 2022
@Mugurell
For mozilla-mobile#27549 - Collect shim data about the Pocket sponsor…
5d1ba05 
…ed stories.

With the new telemetry will immediately report when a certain Pocket sponsored
story is shown (visible more than 50%) or clicked by the user.
The reasons for the new ping help easily identify the probe being sent and the
type of shim data.
Mugurell added a commit to Mugurell/fenix that referenced this issue Nov 10, 2022
@Mugurell
For mozilla-mobile#27549 - Collect shim data about the Pocket sponsor…
c653be9 
…ed stories.

With the new telemetry will immediately report when a certain Pocket sponsored
story is shown (visible more than 50%) or clicked by the user.
The reasons for the new ping help easily identify the probe being sent and the
type of shim data.
@mergify mergify bot closed this as completed in #27550 Nov 10, 2022
mergify bot pushed a commit that referenced this issue Nov 10, 2022
@Mugurell @mergify
For #27549 - Collect shim data about the Pocket sponsored stories.
18d51d9 
With the new telemetry will immediately report when a certain Pocket sponsored
story is shown (visible more than 50%) or clicked by the user.
The reasons for the new ping help easily identify the probe being sent and the
type of shim data.
@github-actions github-actions bot reopened this Nov 10, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 10, 2022
@github-actions github-actions bot added this to the 108 milestone Nov 10, 2022
@Mugurell
Copy link
Contributor Author

Testing the just landing code I see the shim data is sent immediately and contains the expected values - https://debug-ping-preview.firebaseapp.com/pings/spocShims.

@Mugurell Mugurell removed the eng:qa:needed QA Needed label Nov 10, 2022
This was referenced Dec 14, 2022
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@Mugurell @mergify
[fenix] For mozilla-mobile/fenix#27549 - Collect shim data about the …
83fc260 
…Pocket sponsored stories.

With the new telemetry will immediately report when a certain Pocket sponsored
story is shown (visible more than 50%) or clicked by the user.
The reasons for the new ping help easily identify the probe being sent and the
type of shim data.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
Feature:PocketIntegration Feature:Telemetry needs:triage Issue needs triage
Projects
None yet
Milestone
108
2 participants
@Dexterp37 @Mugurell