Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add Lint rule to enforce import ordering #27667

Closed
MozillaNoah opened this issue Nov 2, 2022 · 0 comments · Fixed by #27680, #27703, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Closed

Add Lint rule to enforce import ordering #27667

MozillaNoah opened this issue Nov 2, 2022 · 0 comments · Fixed by #27680, #27703, fork-house/fenix#14, Leland-Takamine/fenix#159 or nathanmkaya/fenix#108
Assignees
@gabrielluong
Labels
eng:health Improve code health
Milestone
108

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Nov 2, 2022 •
edited by data-sync-user
Loading

https://pinterest.github.io/ktlint/rules/standard/#import-ordering

┆Issue is synchronized with this Jira Task
┆Link To Issue: https://mozilla-hub.atlassian.net/browse/FNXV2-21916
@MozillaNoah MozillaNoah added the eng:health Improve code health label Nov 2, 2022
@MozillaNoah MozillaNoah mentioned this issue Nov 2, 2022
Merged
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 2, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Nov 2, 2022
@MozillaNoah MozillaNoah changed the title Add Lint rule to enforce import sorting Add Lint rule to enforce import ordering Nov 2, 2022
@gabrielluong gabrielluong self-assigned this Nov 3, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 3, 2022
@gabrielluong
For mozilla-mobile#27667 - Remove import-ordering from the list of di…
463fcd5 
…sabled ktlint rules
@github-actions github-actions bot mentioned this issue Nov 3, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 3, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 3, 2022
@gabrielluong
For mozilla-mobile#27667 - Remove import-ordering from the list of di…
78f4003 
…sabled ktlint rules
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 3, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 3, 2022
@gabrielluong
For mozilla-mobile#27667 - Remove import-ordering from the list of di…
6aad79d 
…sabled ktlint rules
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 3, 2022
@gabrielluong
For mozilla-mobile#27667 - Remove import-ordering from the list of di…
269fa72 
…sabled ktlint rules
@mergify mergify bot closed this as completed in #27680 Nov 3, 2022
mergify bot pushed a commit that referenced this issue Nov 3, 2022
@gabrielluong @mergify
For #27667 - Remove import-ordering from the list of disabled ktlint …
9654b4d 
…rules
@github-actions github-actions bot added this to the 108 milestone Nov 3, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 4, 2022
@gabrielluong
For mozilla-mobile#27667 - Update the commit sha in .git-blame-ignore…
26da02d 
…-revs
@github-actions github-actions bot mentioned this issue Nov 4, 2022
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Nov 4, 2022
@gabrielluong @mergify
For #27667 - Update the commit sha in .git-blame-ignore-revs
5410be0
This was referenced Dec 8, 2022
Merged
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@gabrielluong @mergify
[fenix] For mozilla-mobile/fenix#27667 - Remove import-ordering from …
e3b8878 
…the list of disabled ktlint rules
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@gabrielluong @mergify
[fenix] For mozilla-mobile/fenix#27667 - Update the commit sha in .gi…
ddfe5d3 
…t-blame-ignore-revs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
eng:health Improve code health
Projects
None yet
Milestone
108
2 participants
@gabrielluong @MozillaNoah