Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Option to disable screenshots in private mode #2768

Closed
vesta0 opened this issue May 23, 2019 · 35 comments · Fixed by #9659
Closed

Option to disable screenshots in private mode #2768

vesta0 opened this issue May 23, 2019 · 35 comments · Fixed by #9659
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:PrivateBrowsing needs:l10n Has strings that will require translation from the l10n team

Comments

@vesta0
Copy link
Collaborator

vesta0 commented May 23, 2019

User Story

  • As a user, I want the option to disable taking screenshots in private browsing mode, so I can further protect my privacy.

Acceptance Criteria

  • I can disable taking screenshots in private mode (off by default)
  • When disabled in private mode, I am not able to take a screenshot and instead I see a system notification indicating that taking screenshots isn't allowed in private mode.
  • I don't see the contents of my private tab in Android multitasking view

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to the Post-MVP Backlog milestone May 23, 2019
@topotropic
Copy link

We should use a system notification, similar to what Focus does.

@vesta0
Copy link
Collaborator Author

vesta0 commented May 23, 2019

Sounds good @topotropic

@buttercookie42
Copy link

Should this be configurable - not least for bug reports and suchlike?

@vesta0 vesta0 added could and removed P1 Current sprint labels Jul 2, 2019
@vesta0 vesta0 modified the milestones: Backlog, Q3 Feature Backlog Jul 2, 2019
@joebloggs7657
Copy link

Could this not be an option? Being able to take screenshots in private mode doesnt exactly compromise the premise of private browsing. I will say from experience in Bromite that not being able to screenshot is more of a hassle than anything related to private browsing.

@yoasif
Copy link
Contributor

yoasif commented Jul 9, 2019

This should be an option - perhaps even default behavior, but an option nonetheless, imo.

@ekager
Copy link
Contributor

ekager commented Jul 10, 2019

If we do this, I think we should make it off by default. From Focus experience, not all users understand or want this feature, and the ones that want it are probably more likely to understand how to seek it out.

@lime124
Copy link
Collaborator

lime124 commented Jul 23, 2019

removing the ux label - this is on our radar already as it's part of Q3 plans.

@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@Djfe
Copy link

Djfe commented Aug 7, 2019

this is the same bug as
#2248
#3422
#3707

I think 3 of the 4 bugs should be closed as duplicates :)

@Mugurell Mugurell moved this from In Progress to In Dev Review in Fenix Sprint Kanban Apr 3, 2020
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Apr 6, 2020
 Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Apr 6, 2020
 Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Apr 7, 2020
 Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
@BMEduard BMEduard linked a pull request Apr 7, 2020 that will close this issue
4 tasks
BMEduard pushed a commit to BMEduard/fenix that referenced this issue Apr 7, 2020
 Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
Mugurell pushed a commit that referenced this issue Apr 7, 2020
 Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
@project-bot project-bot bot moved this from In Dev Review to Sprint 20.4 Done in Fenix Sprint Kanban Apr 7, 2020
@BMEduard BMEduard added the eng:qa:needed QA Needed label Apr 7, 2020
@BMEduard BMEduard moved this from Sprint 20.4 Done to Ready for QA in Fenix Sprint Kanban Apr 7, 2020
@sv-sdeiac
Copy link

Hi, I can confirm that the new feature is implemented using the latest version of Firefox Preview Nightly 4/8 #20990609.
Also, I can confirm that the issue works properly. Disabling the option is blocking the device to take screenshots and it blanks the videos. Enabling the option allows the device to take screenshots and videos.

Devices:

  • LG g7 fit (Android 8.1);
  • Samsung Galaxy Note 8 (Android 9);
  • Google Pixel 3 (Android 10).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 8, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint 20.4 Done in Fenix Sprint Kanban Apr 8, 2020
@Poopooracoocoo
Copy link

@brampitoyo said:

One thing we have to keep in mind is the “unintended consequence” that turning this option on will also cause Fenix private mode not to show a screenshot in the app manager view – effectively hiding potentially incriminating content. It’s a nice privacy feature, and one that we ought to include when explaining this feature.

a subtext could be added to explain this. @BMEduard whaddya think?

@BMEduard
Copy link
Contributor

BMEduard commented Apr 13, 2020

I think this is a question for UX, @AmyYLee what do you think?

@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 13, 2020

I think this is a question for UX, @AmyYLee what do you think?

Do you mean subtext in the private browsing home screen when the user has no tabs opened? Asking @betsymi for her input.
Screen Shot 2020-04-13 at 09 42 28

@liuche liuche mentioned this issue Apr 13, 2020
32 tasks
@Poopooracoocoo
Copy link

@AmyYLee no a subtext of the disable screenshot option that tells users that Fenix's content will be hidden in the app switcher

@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 14, 2020

@AmyYLee no a subtext of the disable screenshot option that tells users that Fenix's content will be hidden in the app switcher

@Poopooracoocoo Can you post the screen of what you are referring to?

@Poopooracoocoo
Copy link

@AmyYLee
Screenshot
The "Allow screenshots in private browsing" option should also include a description that tells users that it also hides Firefox's content in the app switcher.

@liuche liuche mentioned this issue Apr 28, 2020
32 tasks
@data-sync-user data-sync-user changed the title Option to disable screenshots in private mode FNX2-18262 ⁃ Option to disable screenshots in private mode Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18262 ⁃ Option to disable screenshots in private mode FNX3-16568 ⁃ Option to disable screenshots in private mode Aug 11, 2020
@Mugurell
Copy link
Contributor

Closing as per #2768 (comment)

@data-sync-user data-sync-user changed the title FNX3-16568 ⁃ Option to disable screenshots in private mode Option to disable screenshots in private mode May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:PrivateBrowsing needs:l10n Has strings that will require translation from the l10n team
Projects
No open projects
Fenix Q2 Feature Backlog
Differentiate through privacy
Development

Successfully merging a pull request may close this issue.