Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Clear private data on exit #3700

Closed
yoasif opened this issue Jun 27, 2019 · 21 comments
Closed

Clear private data on exit #3700

yoasif opened this issue Jun 27, 2019 · 21 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:FennecTransition needs:sumo Mozilla Suport - suport.mozilla.org
Milestone

Comments

@yoasif
Copy link
Contributor

yoasif commented Jun 27, 2019

Why/User Benefit/User Problem

  • As a user, I want my browser to always clear certain data chosen by me when close the browser.

Types of data:

-Open Tabs
-Browsing history
-Search history
-Cookies and site data
-Cached images and files
-Site settings

Requirements

  • Behind a Feature Flag so QA can spend extra time testing

Acceptance Criteria

  • When I close the browser, the data I chose to clear is cleared by Fenix.
  • TBD: UX to determine what Recent Tasks behavior looks like

UX Spec
https://mozilla.invisionapp.com/share/4BTIO3EECQU

┆Issue is synchronized with this Jira Task

@yoasif yoasif added the feature request 🌟 New functionality and improvements label Jun 27, 2019
@vesta0 vesta0 added Feature:FennecTransition must and removed feature request 🌟 New functionality and improvements labels Jul 3, 2019
@vesta0 vesta0 changed the title Clear private data on exit (Fennec parity) Clear private data on exit Jul 3, 2019
@vesta0 vesta0 added this to the Q3 Feature Backlog milestone Jul 3, 2019
@joebloggs7657
Copy link

joebloggs7657 commented Jul 9, 2019

Hi please can you tie this feature to the app being closed from the app switcher instead please, Firefox Focus style? I dont think selecting quit from the app menu is common usage nor is this in parity with the desktop firefox implementation . I'm aware that you'll probably need a technical work around but I hope it's still possible by some of your capable devs.
I refer to the feature more so as "Clear private data between sessions" than "on exit".

@yoasif
Copy link
Contributor Author

yoasif commented Jul 9, 2019

Per this comment: #2152 (comment)

Android does not provide a way to tell the difference between a user swiping an app closed and the app being killed in the background.

@joebloggs7657
Copy link

Firefox focus manages to do it on Android? Maybe it would be a separate feature request but taking from that implementation would be great imo.

@yoasif
Copy link
Contributor Author

yoasif commented Jul 9, 2019

Focus manages it with a persistent notification AFAIK.

@joebloggs7657
Copy link

Oh right that makes sense since Bromite incognito also uses a notification.
Should I make a separate issue to request a similar implementation or something?

@lime124
Copy link
Collaborator

lime124 commented Jul 23, 2019

removing the ux label - this is on our radar already as it's part of Q3 plans.

@lime124 lime124 removed the needs:UX-feedback Needs UX Feedback label Jul 23, 2019
@liuche liuche added this to To be Triaged in Fenix Sprint Kanban via automation Jul 25, 2019
@lime124 lime124 moved this from To be Triaged to Prioritized UX Backlog in Fenix Sprint Kanban Jul 25, 2019
@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@liuche
Copy link
Contributor

liuche commented Aug 6, 2019

QA has said they'd like a little extra time to test this, so this should be ideally behind a feature flag.

@vesta0 vesta0 moved this from Prioritized UX Backlog to In Design in Fenix Sprint Kanban Aug 12, 2019
@apbitner apbitner added the ux:s label Aug 13, 2019
@bifleming bifleming added this to Prioritized Backlog in Fennec to Fenix Transition Aug 14, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 9, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 10, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 10, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 11, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 11, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 11, 2019
ekager added a commit to ekager/fenix that referenced this issue Sep 11, 2019
@ekager ekager added the eng:qa:needed QA Needed label Sep 11, 2019
@ekager
Copy link
Contributor

ekager commented Sep 11, 2019

This Setting is behind a feature flag for now

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Sep 12, 2019

This is in the RC 2.0-rc2 milestone but can be verified for now only in Nightly.
@ekager Is it correctly included in the 2.0 milestone?

@sblatz sblatz moved this from In Progress to Ready for QA in Fenix Sprint Kanban Sep 12, 2019
@ekager ekager modified the milestones: v2.0, v2.1 Sep 14, 2019
@ekager
Copy link
Contributor

ekager commented Sep 14, 2019

Moved it to the next milestone!

@ekager
Copy link
Contributor

ekager commented Sep 14, 2019

If the user is in PBM we should always blank out the screen in the recent apps tray.

This discussion is out of scope for this ticket and is being discussed here #2768

@sv-ohorvath
Copy link
Contributor

@AmyYLee @vesta0 The homescreen menu doesn't have the Quit option. In my opinion it would make sense to have it there as well, considering it's something you want at hand when you need to quit the browser. What do you think?

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Sep 19, 2019

Otherwise this is verified as fixed on Nightly 9/18. Let me know if you want me to create a new issue for the comment above.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 19, 2019
@project-bot project-bot bot moved this from Ready for QA to In Progress in Fenix Sprint Kanban Sep 19, 2019
@ekager
Copy link
Contributor

ekager commented Sep 19, 2019

Thanks @sv-ohorvath ! I filed #5442 for the follow up

@ekager ekager closed this as completed Sep 19, 2019
Fenix Sprint Kanban automation moved this from In Progress to Done Sep 19, 2019
Fenix Q3 Feature Backlog automation moved this from Must to Done! Sep 19, 2019
@sblatz
Copy link
Contributor

sblatz commented Oct 2, 2019

@ekager @sv-ohorvath is this ready to move from out behind the feature flag?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:FennecTransition needs:sumo Mozilla Suport - suport.mozilla.org
Projects
No open projects
Development

No branches or pull requests