Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Adjust font weight in share sheet #27896

Closed
topotropic opened this issue Nov 18, 2022 · 2 comments · Fixed by #27921, C-EO/fenix#4, fork-house/fenix#14 or nathanmkaya/fenix#108
Closed

[Bug]: Adjust font weight in share sheet #27896

topotropic opened this issue Nov 18, 2022 · 2 comments · Fixed by #27921, C-EO/fenix#4, fork-house/fenix#14 or nathanmkaya/fenix#108
Assignees
@DreVla
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone
109

Comments

@topotropic
Copy link

topotropic commented Nov 18, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

Open share sheet

Screenshot (Nov 11, 2022 1 53 59 PM)

Expected behaviour

Headers have the same font weight

Actual behaviour

Headers have different font weights

Device name

No response

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task
@topotropic topotropic added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage labels Nov 18, 2022
@DreVla DreVla self-assigned this Nov 21, 2022
DreVla added a commit to DreVla/fenix that referenced this issue Nov 21, 2022
@DreVla
For mozilla-mobile#27896 - Match share sheet header style with the rest
c0a7549 
"Send to device" share sheet header is now styled to match the other headers.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Nov 21, 2022
@github-actions github-actions bot mentioned this issue Nov 21, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #27921 Nov 28, 2022
mergify bot pushed a commit that referenced this issue Nov 28, 2022
@DreVla @mergify
For #27896 - Match share sheet header style with the rest
f681171 
"Send to device" share sheet header is now styled to match the other headers.
@github-actions github-actions bot reopened this Nov 28, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Nov 28, 2022
@github-actions github-actions bot added this to the 109 milestone Nov 28, 2022
@github-actions github-actions bot mentioned this issue Nov 28, 2022
Merged
@AdinaPetridean
Copy link

Verified as fixed on Nightly 109.0a1 from 12/03 with Motorola Moto G9 plus (Android 11). Headers have the same font weight.

@AdinaPetridean AdinaPetridean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 5, 2022
@delia-pop
Copy link

Also verified fixed on Beta 109.0b1 with Lenovo Yoga Tab 11 (Android 11).

This was referenced Jan 10, 2023
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@DreVla @mergify
[fenix] For mozilla-mobile/fenix#27896 - Match share sheet header sty…
a8deacc 
…le with the rest

"Send to device" share sheet header is now styled to match the other headers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DreVla DreVla

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Milestone
109
4 participants
@topotropic @DreVla @delia-pop @AdinaPetridean