Picture-in-picture mode

[Lululalu]

Why/User Benefit/User Problem

Android 8.0 allows videos to played floating on the screen. This feature gives a better multi-task and viewing experience.

What/Requirements

Adding PiP support to videos.

Acceptance Criteria (how do I know when I’m done?)

When it's possible to watch a video outside the app thanks to pip support.

---

See eng notes below: #2818 (comment)

How it currently looks on Reference Browser:

UNITO-UNDERSCORE!restricted!

┆Issue is synchronized with this Jira Task

[jonalmeida]

This is an a-c feature already :)

https://github.com/mozilla-mobile/reference-browser/blob/master/app/src/main/java/org/mozilla/reference/browser/browser/BrowserFragment.kt#L187-L194

[suoko]

Samsung internet browser has this feature, a quite nice feature.

[jonalmeida]

@Lululalu I hope you don't mind me hijacking your feature request so I could give it more context. :)

[Lululalu]

@jonalmeida it's OK. Do what's best.

[Poopooracoocoo]

I'd love a custom implementation like NewPipe which gives you PiP on versions before O. Samsung's video player doesn't require O either.

[AmyYLee]

@lime124 I took a look at the reference browser PIP and it seems UX is pretty minimal. Is there any UX requirement for this? I can take it if there is.

[jonalmeida]

I took a look at the reference browser PIP and it seems UX is pretty minimal.

One use case to consider: If a video is in PIP-mode, should you be able to browse other content at the same time? e.g. play a video in PIP and read an article on a different tab. In the reference browser implementation, you can only watch the video and use other apps, not R-B itself.

[lime124]

sorry for being slow @AmyYLee - i agree the it should be a minimal effort. if i recall it's mostly reviewing the implementation. @jonalmeida calls out a good use case to consider and make a decision on. feel free to pick this up amy

[AmyYLee]

I took a look at the reference browser PIP and it seems UX is pretty minimal.

One use case to consider: If a video is in PIP-mode, should you be able to browse other content at the same time? e.g. play a video in PIP and read an article on a different tab. In the reference browser implementation, you can only watch the video and use other apps, not R-B itself.

Hi @jonalmeida if it's possible to play a video in PIP while being able to go to a different tab we should do this. We are able to do this in desktop and I don't see any negatives if we allow this on Fenix.

[ekager]

This is landed behind a Nightly/Debug feature flag for now and should be working for custom tabs and normal browsing.

[sv-sdeiac]

Hi, I can confirm that the PiP mode is working using a Firefox Preview Debug build from master 4/13 GV: 77.0a1.

Devices:

• Google Pixel 3 (Android 10);
• Samsung Galaxy Note 8 (Android 9);
• Xiaomi Mi 8 Lite (Android 9);
• LG g7 fit (Android 8.1).

Additionally, performing the verification I found 3 new bugs related to the feature (9885, 9910, 9911).