Delete All Private Tabs Redesign

[sblatz]

When we originally designed private mode, it was much more like Focus with a trash can easily accessible in the browser fragment.

We chose to remove that here against the original designs, and I would like us to re-consider this change, especially if we want the browser to feel very familiar to Focus users.

Acceptance Criteria

Garbage Icon exists to delete all private tabs
Snackbar pops up once garbage icon is hit (with option to undo)
Remove header text in Private Mode: "You're in a private session"

┆Issue is synchronized with this Jira Task

[cadeyrn]

The important difference between Focus and Fenix is that Focus is a single tab browser (yes, multi tab browser in theory, but only in theory ;-) ), Fenix is not a single tab browser. So the same UX (trash icon in address bar) cannot be applied for Fenix without creating confusion if this icon is used to close all tabs as implemented before because it breaks the mental model that an icon in the address bar / main toolbar is associated with a page specific action. So there should be a confirmation dialog at least to prevent data loss because of wrong expectations of this button.

[joebloggs7657]

The trash can is not very useful in focus and in fact needs to be trashed when focus development restarts imo.
I am however very much happy for Firefox to upgrade it's private browsing experience to be similar to Firefox focus. Maybe the whole app should just be assimilated into the new Firefox!

[cadeyrn]

The trash can is not very useful in focus and in fact needs to be trashed when focus development restarts imo.

In Focus the trash icon is very useful and makes sense but this is not the topic here. Focus and Fenix have totally different usage concepts.

Maybe the whole app should just be assimilated into the new Firefox!

No, I strongly disagree. The USP and greatest strength of Focus is that it's different than all the other browsers, including Firefox / Fenix. Of course Fenix should also get as much privacy features as possible but that doesn't mean at all there's no longer a reason to exist for Focus.

[lobontiumira]

Verified that the garbage icon exists to delete all private tabs, and a snackbar pops up once garbage icon is hit (with the option to undo) on the Nightly build 190821 (#12330640), and debug build 1.0.1934 (a-c 10.0.0, e94e6cc8e, 70.0a1-20190821095414 gecko), with Nexus 9 (Android 7.1.1), and Samsung Galaxy Note 8 (Android 9).