Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #2834: Delete all Private Tabs redesign #4787

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

jyeontaek
Copy link
Contributor

@jyeontaek jyeontaek commented Aug 16, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@jyeontaek jyeontaek requested a review from a team as a code owner August 16, 2019 23:57
@jyeontaek
Copy link
Contributor Author

@sblatz Did we want to add tests for this feature as well?

@codecov-io
Copy link

codecov-io commented Aug 17, 2019

Codecov Report

Merging #4787 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4787      +/-   ##
===========================================
- Coverage      7.05%   7.02%   -0.04%     
  Complexity      145     145              
===========================================
  Files           213     213              
  Lines          8978    8988      +10     
  Branches       1352    1355       +3     
===========================================
- Hits            633     631       -2     
- Misses         8305    8317      +12     
  Partials         40      40
Impacted Files Coverage Δ Complexity Δ
.../sessioncontrol/viewholders/TabHeaderViewHolder.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...rc/main/java/org/mozilla/fenix/BrowserDirection.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c076cc8...6521aef. Read the comment docs.

@sblatz
Copy link
Contributor

sblatz commented Aug 20, 2019

@jyeontaek just some linting errors to fix too:
image

@jyeontaek jyeontaek force-pushed the issue_2834 branch 2 times, most recently from f2cf14a to 9922c37 Compare August 20, 2019 18:48
@jyeontaek jyeontaek added this to the v1.4 milestone Aug 20, 2019
@jyeontaek jyeontaek merged commit 6f899c7 into mozilla-mobile:master Aug 20, 2019
jyeontaek added a commit that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants