This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #2834: Delete all Private Tabs redesign #4787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sblatz Did we want to add tests for this feature as well? |
Codecov Report
@@ Coverage Diff @@
## master #4787 +/- ##
===========================================
- Coverage 7.05% 7.02% -0.04%
Complexity 145 145
===========================================
Files 213 213
Lines 8978 8988 +10
Branches 1352 1355 +3
===========================================
- Hits 633 631 -2
- Misses 8305 8317 +12
Partials 40 40
Continue to review full report at Codecov.
|
NotWoods
suggested changes
Aug 19, 2019
app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt
Outdated
Show resolved
Hide resolved
NotWoods
approved these changes
Aug 20, 2019
app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabHeaderViewHolder.kt
Outdated
Show resolved
Hide resolved
@jyeontaek just some linting errors to fix too: |
f2cf14a
to
9922c37
Compare
jyeontaek
added a commit
that referenced
this pull request
Aug 20, 2019
This reverts commit 6f899c7.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist