Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[BUG] change RTL/LTR languages doesn't update the UI until new launch #28342

Closed
mavduevskiy opened this issue Dec 29, 2022 · 1 comment · Fixed by #28343
Closed

[BUG] change RTL/LTR languages doesn't update the UI until new launch #28342

mavduevskiy opened this issue Dec 29, 2022 · 1 comment · Fixed by #28343
Assignees
@mavduevskiy
Labels
eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Milestone
111

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Dec 29, 2022 •
edited by data-sync-user

Issue that was mentioned here.

Switching from an RTL to an LTR locale (or vice versa) doesn't update the UI direction without restarting Fenix first

Steps to reproduce

Go to language screen and change the language to a language with the opposite direction from the one you are currently using.

Expected behaviour

The layout of the app will change to accommodate the direction of the set language.

Actual behaviour

The direction of the layout keeps the same until relaunching the app.

┆Issue is synchronized with this Jira Task
@mavduevskiy mavduevskiy self-assigned this Dec 29, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 29, 2022
@mavduevskiy mavduevskiy removed the needs:triage Issue needs triage label Dec 29, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Dec 29, 2022
Closes mozilla-mobile#28342: change the ui direction after a locale c…
261a6f8 
…hange
@github-actions github-actions bot mentioned this issue Dec 29, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 29, 2022
@delia-pop delia-pop mentioned this issue Jan 16, 2023
Closed
@mergify mergify bot closed this as completed in #28343 Jan 20, 2023
mergify bot pushed a commit that referenced this issue Jan 20, 2023
@mergify
Closes #28342: change the ui direction after a locale change
26551b6
@github-actions github-actions bot reopened this Jan 20, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 20, 2023
@github-actions github-actions bot added this to the 111 milestone Jan 20, 2023
@delia-pop
Copy link

Verified as fixed on Nightly 111.0a1 from 01/20 with Xiaomi 12 Pro (Android 13). The UI changes accordingly after switching between RTL/LTR languages.

Screenrecorder-2023-02-04-15-57-18-603.mp4

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 20, 2023
t-p-white pushed a commit to t-p-white/fenix that referenced this issue Jan 20, 2023
Closes mozilla-mobile#28342: change the ui direction after a locale c…
73f6b76 
…hange
@github-actions github-actions bot mentioned this issue Jan 20, 2023
Closed
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jan 20, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
@mergify
[fenix] Closes mozilla-mobile/fenix#28342: change the ui direction af…
0b7f5f7 
…ter a locale change
akliuxingyuan pushed a commit to akliuxingyuan/iceraven-browser that referenced this issue Mar 15, 2023
@mergify
[fenix] Closes mozilla-mobile#28342: change the ui direction after a …
f14943a 
…locale change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Projects
None yet
Milestone
111
2 participants
@delia-pop @mavduevskiy