Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Rename InactiveTabsController's functions #28516

Closed
Tracked by #25722
MozillaNoah opened this issue Jan 12, 2023 · 0 comments · Fixed by #28517, Leland-Takamine/fenix#160, C-EO/fenix#4 or fork-house/fenix#14
Closed
Tracked by #25722

Rename InactiveTabsController's functions #28516

MozillaNoah opened this issue Jan 12, 2023 · 0 comments · Fixed by #28517, Leland-Takamine/fenix#160, C-EO/fenix#4 or fork-house/fenix#14
Assignees
@MozillaNoah
Labels
eng:health Improve code health eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Milestone
110

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Jan 12, 2023 •
edited
Loading

Refactor the names to ensure that the names are clear that functions are for inactive tabs and handling user actions.

Also take this opportunity to make any changes to the kdocs.

┆Issue is synchronized with this Jira Task
@MozillaNoah MozillaNoah added the eng:health Improve code health label Jan 12, 2023
@MozillaNoah MozillaNoah self-assigned this Jan 12, 2023
@MozillaNoah MozillaNoah mentioned this issue Jan 12, 2023
Closed
13 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 12, 2023
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Jan 12, 2023
@github-actions github-actions bot mentioned this issue Jan 12, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #28517 Jan 12, 2023
mergify bot pushed a commit that referenced this issue Jan 12, 2023
@MozillaNoah @mergify
For #28516 - Update InactiveTabsController function names
ddc605e
@github-actions github-actions bot added this to the 110 milestone Jan 12, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
@MozillaNoah @mergify
[fenix] For mozilla-mobile/fenix#28516 - Update `InactiveTabsControll…
905cab2 
…er` function names
@github-actions github-actions bot mentioned this issue Feb 8, 2023
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Feb 8, 2023
This was referenced Feb 9, 2023
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
eng:health Improve code health eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged
Projects
None yet
Milestone
110
1 participant
@MozillaNoah