Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Enable notification pre permission prompt feature in Beta #28597

Closed
rocketsroger opened this issue Jan 19, 2023 · 2 comments · Fixed by #28598
Closed

Enable notification pre permission prompt feature in Beta #28597

rocketsroger opened this issue Jan 19, 2023 · 2 comments · Fixed by #28598
Assignees
@rocketsroger
Labels
eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged needs:triage Issue needs triage
Milestone
111

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Jan 19, 2023 •
edited by data-sync-user
Loading

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger self-assigned this Jan 19, 2023
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 19, 2023
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jan 19, 2023
@rocketsroger
Close mozilla-mobile#28597: Enable notification pre permission prompt…
833023a 
… feature in Beta
@github-actions github-actions bot mentioned this issue Jan 19, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #28598 Jan 19, 2023
mergify bot pushed a commit that referenced this issue Jan 19, 2023
@rocketsroger @mergify
Close #28597: Enable notification pre permission prompt feature in Beta
8ddd840
@github-actions github-actions bot added this to the 111 milestone Jan 19, 2023
mergify bot pushed a commit that referenced this issue Jan 19, 2023
@rocketsroger @mergify
Close #28597: Enable notification pre permission prompt feature in Beta
fee6b61 
(cherry picked from commit 8ddd840)
rocketsroger added a commit that referenced this issue Jan 20, 2023
@mergify @rocketsroger
Close #28597: Enable notification pre permission prompt feature in Be…
760df69 
…ta (#28599)

(cherry picked from commit 8ddd840)

Co-authored-by: Roger Yang <royang@mozilla.com>
rocketsroger added a commit that referenced this issue Jan 20, 2023
@rocketsroger
Revert "Close #28597: Enable notification pre permission prompt featu…
2725cee 
…re in Beta (#28599)"

This reverts commit 760df69.
t-p-white pushed a commit to t-p-white/fenix that referenced this issue Jan 20, 2023
@rocketsroger
Close mozilla-mobile#28597: Enable notification pre permission prompt…
eb2d99f 
… feature in Beta
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jan 20, 2023
@github-actions github-actions bot mentioned this issue Jan 20, 2023
Closed
4 tasks
@delia-pop
Copy link

Tested on Beta 110.0b3 with Xiaomi 12 Pro (Android 13). The pre permission prompt is not available in the current Beta version, as expected.

JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
@rocketsroger @mergify
[fenix] Close mozilla-mobile/fenix#28597: Enable notification pre per…
9080605 
…mission prompt feature in Beta
@SoftVision-LorandJanos
Copy link

Verified in the latest Beta build (110.0b6).
The Pre-permission prompt is enabled and works as expected.
Android Pre-Permission Prompt Experiment needs to be set to Treatment branch in order for this feature to be active.
Verified on the following devices:

  • Google Pixel 4 (Android 13).
  • Samsung Galaxy A53 5G (Android 13).
    Adding the verified label.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 16, 2023
@mergify @rocketsroger
[fenix] Close mozilla-mobile/fenix#28597: Enable notification pre per…
aa134cf 
…mission prompt feature in Beta (mozilla-mobile/fenix#28599)

(cherry picked from commit 8ddd840)

Co-authored-by: Roger Yang <royang@mozilla.com>
akliuxingyuan pushed a commit to akliuxingyuan/iceraven-browser that referenced this issue Mar 15, 2023
@rocketsroger @mergify
[fenix] Close mozilla-mobile#28597: Enable notification pre permissio…
0301d42 
…n prompt feature in Beta
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
eng:qa:verified QA Verified eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged needs:triage Issue needs triage
Projects
None yet
Milestone
111
3 participants
@rocketsroger @SoftVision-LorandJanos @delia-pop