Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add confirmation dialog to sign out of FxA #3134

Closed
boek opened this issue Jun 4, 2019 · 2 comments
Closed

Add confirmation dialog to sign out of FxA #3134

boek opened this issue Jun 4, 2019 · 2 comments
Assignees
@ekager
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Sync
Milestone
v1.1

Comments

@boek
Copy link
Contributor

boek commented Jun 4, 2019 •
edited by data-sync-user
Loading

Why/User Benefit/User Problem

Make sure users actually want to sign out and disconnect Fenix from their FxA

What/Requirements

image

Acceptance Criteria (how do I know when I’m done?)

There is now a confirmation dialog to sign out

┆Issue is synchronized with this Jira Task
@boek boek added the feature request 🌟 New functionality and improvements label Jun 4, 2019
@boek boek mentioned this issue Jun 4, 2019
Closed
@vesta0 vesta0 added the P1 Current sprint label Jun 4, 2019
@vesta0 vesta0 added this to the Fenix 1.1 Backlog milestone Jun 4, 2019
@vesta0 vesta0 removed P1 Current sprint labels Jun 21, 2019
@vesta0 vesta0 removed the feature request 🌟 New functionality and improvements label Jul 3, 2019
@ekager ekager self-assigned this Jul 4, 2019
@ekager ekager mentioned this issue Jul 4, 2019
Closed
@vesta0 vesta0 modified the milestones: 1.1 Backlog, Q3 Feature Backlog Jul 5, 2019
@sblatz sblatz mentioned this issue Jul 9, 2019
Closed
@vesta0 vesta0 added eng:ready Ready for engineering needs:strings Needs strings labels Jul 9, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 10, 2019
@ekager
For mozilla-mobile#3134 - Add confirmation dialog to sign out of FxA
03c0f77
@vesta0 vesta0 added the eng:qa:needed QA Needed label Jul 10, 2019
@liuche liuche removed the needs:strings Needs strings label Jul 10, 2019
@lobontiumira
Copy link

This is not fixed yet. There is no confirmation dialog that the user had signed out of FxA.
Teste with a debug build 1.0.1928 GV 68.0-20190612114833 with Motorola Nexus 6 (Android 7,1,1), and Motorola Moto G6 (Android 8).

@lobontiumira lobontiumira added in progress and removed eng:qa:needed QA Needed labels Jul 11, 2019
ekager added a commit to ekager/fenix that referenced this issue Jul 11, 2019
@ekager
For mozilla-mobile#3134 - Add confirmation dialog to sign out of FxA
da15669
ekager added a commit to ekager/fenix that referenced this issue Jul 12, 2019
@ekager
For mozilla-mobile#3134 - Add confirmation dialog to sign out of FxA
9629bda
ekager added a commit to ekager/fenix that referenced this issue Jul 15, 2019
@ekager
For mozilla-mobile#3134 - Add confirmation dialog to sign out of FxA
5122798
boek pushed a commit that referenced this issue Jul 15, 2019
@ekager @boek
For #3134 - Add confirmation dialog to sign out of FxA (#3959)
13b7e64
@ekager ekager added the eng:qa:needed QA Needed label Jul 16, 2019
@lobontiumira
Copy link

Verified that there is a confirmation dialog when signing out.
Tested on the latest Nightly build 190717 (#11980613) with Sony Xperia Z5 Premium (Android 7.1.1), Samsung Galaxy Tab A6 (Android 5.1.1), and HTC 10 (Android 8), and on the latest Nightly build 190717 (#11980614) (aarch64) with Nexus 6P (Android 8.1.0).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed in progress labels Jul 17, 2019
@AndiAJ AndiAJ mentioned this issue Jul 19, 2019
Closed
@colintheshots colintheshots modified the milestones: 1.1 Backlog, v1.1 Jul 23, 2019
@data-sync-user data-sync-user changed the title Add confirmation dialog to sign out of FxA FNX3-16810 ⁃ Add confirmation dialog to sign out of FxA Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16810 ⁃ Add confirmation dialog to sign out of FxA Add confirmation dialog to sign out of FxA May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Sync
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
8 participants
@colintheshots @liuche @boek @NotWoods @ekager @lobontiumira @vesta0 @data-sync-user