Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] Three-dot menu is reopened when double tapped anywhere outside the opened menu #3584

Closed
lobontiumira opened this issue Jun 20, 2019 · 6 comments
Closed

[Bug][a11y] Three-dot menu is reopened when double tapped anywhere outside the opened menu #3584

lobontiumira opened this issue Jun 20, 2019 · 6 comments
Assignees
@Mugurell
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. b:tablet Issue can only be encountered using a tablet 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen.
Milestone
v2.2

Comments

@lobontiumira
Copy link

lobontiumira commented Jun 20, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Turn Talkback on.
  2. Tap on three-dot menu.
  3. Exit the menu double-tapping outside it.

Expected behavior

Double tapping outside the menu should dismiss the menu.

Actual behavior

The three-dot menu is opened again and again when tapping anywhere outside the menu.

Device information

  • Android device: Samsung Galaxy Tab S3 (Android 8)
  • Fenix version: 1.0.0-rc.2 (#11700147)

menu1

┆Issue is synchronized with this Jira Task
@lobontiumira lobontiumira added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. labels Jun 20, 2019
@kbrosnan kbrosnan added b:tablet Issue can only be encountered using a tablet Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. labels Jun 20, 2019
@pdjstone
Copy link

I get a similar issue on my phone - if I double-tap the three-dot menu button, it opens twice (you have to complete the double-tap before the menu opens, a slower device probably helps). Two separate taps outside the menu are needed to close both.

@mcarare
Copy link
Contributor

mcarare commented Jul 19, 2019

I think the first issue mentioned is actually the correct way to respond to a double tap, when a button is selected. The official documentation mentions:"When the focus reaches an item you'd like to select, double-tap anywhere on the screen to select the focused item" (https://support.google.com/accessibility/android/answer/6006598?hl=en).

The second issue mentioned is that due to the above functionality, after a double tap, the button still has focus and has the same onClickListener, and if you double tap it another settings pop-up is shown.

There are three approaches to fix this :

  • change the listener to dismiss the settings pop-up when it is already opened (chrome, skype and others do that)
  • check if popup is already shown and prevent showing a second one
  • remove focus from button after pop-up is shown.

Which one would be the preferred approach?

@Mugurell Mugurell added the needs:UX-feedback Needs UX Feedback label Jul 19, 2019
@lime124
Copy link
Collaborator

lime124 commented Jul 24, 2019

I think this is more of an eng ask of how they want to fix the bug? /cc @boek

@lime124 lime124 removed the needs:UX-feedback Needs UX Feedback label Jul 24, 2019
@mcarare mcarare mentioned this issue Jul 26, 2019
Closed
@BlindMoon38
Copy link

As a regular screen reader user, dismissing the menu if already open is what I expect, since most applications do this.

@ekager ekager mentioned this issue Aug 2, 2019
Closed
@mcarare mcarare mentioned this issue Sep 27, 2019
Closed
@Mugurell Mugurell self-assigned this Sep 27, 2019
@Mugurell Mugurell mentioned this issue Sep 30, 2019
Closed
bors bot pushed a commit that referenced this issue Oct 10, 2019
@MozLando
Merge #5674
44aab98 
5674: For #3584 - Check if menu is open before showing a new one r=sblatz a=Mugurell

Add a simple check for if the menu is showing depending on which we will know not to construct and show a new menu.
This check is to be done by both the "Open tabs menu" and the "Home menu"


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks
- [x] **Tests**: This PR does not includes tests as it only contains small changes in not yet tested components
- [x] **Screenshots**: This PR does not include screenshots because there are no UI changes, just small behavior ones which are easy to test.
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md)

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: Petru Lingurar <petru.lingurar@softvision.ro>
sblatz pushed a commit that referenced this issue Oct 10, 2019
@Mugurell @sblatz
For #3584 - Check if menu is open before showing a new one (#5674)
8f0325c 
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
@sblatz sblatz added the eng:qa:needed QA Needed label Oct 10, 2019
@sblatz sblatz added this to the v2.2 milestone Oct 10, 2019
@sv-ohorvath
Copy link
Contributor

Verified as fixed. The settings option is selected by default now when you open the 3 dot menu.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 14, 2019
@data-sync-user data-sync-user changed the title [Bug][a11y] Three-dot menu is reopened when double tapped anywhere outside the opened menu FNX3-17135 ⁃ [Bug][a11y] Three-dot menu is reopened when double tapped anywhere outside the opened menu Aug 11, 2020
@Mugurell
Copy link
Contributor

Closing as per #3584 (comment)

@data-sync-user data-sync-user changed the title FNX3-17135 ⁃ [Bug][a11y] Three-dot menu is reopened when double tapped anywhere outside the opened menu [Bug][a11y] Three-dot menu is reopened when double tapped anywhere outside the opened menu May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. b:tablet Issue can only be encountered using a tablet 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen.
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
10 participants
@kbrosnan @lime124 @pdjstone @sv-ohorvath @sblatz @Mugurell @lobontiumira @BlindMoon38 @mcarare @data-sync-user