Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

As a user, I'd like to have Fenix available as an Assistant #390

Closed
colintheshots opened this issue Feb 6, 2019 · 4 comments
Closed

As a user, I'd like to have Fenix available as an Assistant #390

colintheshots opened this issue Feb 6, 2019 · 4 comments
Assignees
Labels
eng:qa:verified QA Verified

Comments

@colintheshots
Copy link
Contributor

colintheshots commented Feb 6, 2019

Why/User Benefit/User Problem

The assistant button on most phones is the fastest way to access an app. Fennec and Focus support replacing the Google Assistant if the user wishes to.

What / Requirements

It takes a trivial change to the Android manifest.

Acceptance Criteria (how do I know when I’m done?)

The user can select Fenix as assistant and then Fenix appears when hitting the assistant button.

┆Issue is synchronized with this Jira Task

@buttercookie42
Copy link

It takes a trivial change to the Android manifest.

https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/mobile/android/base/AndroidManifest.xml.in#140-154

The user can select Fenix as assistant and then Fenix appears when hitting the assistant button.

Fennec also opens a new tab and puts the input focus on the URL bar, in case this might be worth considering here as well.

@colintheshots
Copy link
Contributor Author

Oh, I know it's pretty trivial. I need issues to track the work, even if it's a one-line change. We have higher priority items, so I want to put this in the backlog for when anyone has time.

@bbinto bbinto added the size S label Feb 8, 2019
@bbinto bbinto added this to the Milestone 2 Backlog milestone Feb 8, 2019
@boek boek self-assigned this Feb 13, 2019
boek added a commit to boek/fenix that referenced this issue Feb 13, 2019
@ghost ghost added in progress labels Feb 13, 2019
@boek boek closed this as completed in 2fa8149 Feb 13, 2019
@ghost ghost removed in progress labels Feb 13, 2019
@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label Feb 13, 2019
@sv-ohorvath
Copy link
Contributor

Verified it works on Samsung Galaxy Note 8 (Android 8.0), Pixel (Android 9)

@buttercookie42
Copy link

Does that mean no special action in response to that Intent?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified
Projects
None yet
Development

No branches or pull requests

5 participants