Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Open searchbox when trigerring assistant #3722

Closed
phileastv opened this issue Jun 27, 2019 · 7 comments · Fixed by #28101, C-EO/fenix#4 or fork-house/fenix#14
Closed

Open searchbox when trigerring assistant #3722

phileastv opened this issue Jun 27, 2019 · 7 comments · Fixed by #28101, C-EO/fenix#4 or fork-house/fenix#14
Labels
eng:qa:verified QA Verified Feature:AndroidIntegration Feature:FennecTransition feature request 🌟 New functionality and improvements Feature:Search
Milestone
110

Comments

@phileastv
Copy link

phileastv commented Jun 27, 2019 •
edited by data-sync-user
Loading

Why/User Benefit/User Problem

To search the web and avoid Google, i'm currently using the classical Firefox for Android and use it with the Assistant Button (which place the cursor on the searchbox and opens the keyboard), and make the app ready to search. This is very convenient.

Currently thanks to #390 Fenix can be mapped to the assistant button, but doesn't open the keyboard. It's definitely polishing and not a top priority, but would be great if it's the same behavior as the old Firefox.

Acceptance Criteria (how do I know when I’m done?)

Place the text cursor on the searchbox and open the keyboard when I open Fenix with the assistant button.

┆Issue is synchronized with this Jira Task
@phileastv phileastv added the feature request 🌟 New functionality and improvements label Jun 27, 2019
@vesta0 vesta0 added could Feature:FennecTransition and removed feature request 🌟 New functionality and improvements labels Jul 9, 2019
@vesta0 vesta0 added this to the Q3 Feature Backlog milestone Jul 9, 2019
@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@vesta0 vesta0 removed this from Could in Fenix Q3 Feature Backlog Sep 16, 2019
@vesta0 vesta0 added this to Q4 2019 in Fenix Feature Maturity Sep 16, 2019
@vesta0 vesta0 removed this from Could in Fenix Q4 Feature Backlog Oct 17, 2019
@vesta0 vesta0 moved this from Q4 2019 to Q1 2020 in Fenix Feature Maturity Oct 17, 2019
@vesta0 vesta0 moved this from Q1 2020 to Won't do in Fenix Feature Maturity Feb 5, 2020
@vesta0 vesta0 removed this from Could in Fenix Q1 Feature Backlog Feb 5, 2020
@vesta0 vesta0 removed this from Could in Fenix Q2 Feature Backlog Mar 29, 2020
@vesta0 vesta0 removed this from After initial launch (fast followers) in Fenix Feature Maturity Mar 29, 2020
@vesta0 vesta0 added the feature request 🌟 New functionality and improvements label Mar 29, 2020
@kbrosnan kbrosnan mentioned this issue Apr 28, 2020
Closed
@JoGarWeb
Copy link

One year later... Don't forget this feature !! I'm really miss this in Fenix 😭😭😭

@s-ankur s-ankur mentioned this issue Aug 20, 2020
Closed
@kbrosnan kbrosnan mentioned this issue Aug 31, 2020
Closed
@s-ankur s-ankur mentioned this issue Sep 25, 2020
Closed
s-ankur added a commit to s-ankur/fenix that referenced this issue Oct 5, 2020
@s-ankur
For mozilla-mobile#3722: Handle the assist intent inside StartSearchI…
391b48a 
…ntentProcessor
s-ankur added a commit to s-ankur/fenix that referenced this issue Oct 17, 2020
@s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
dd334e0
@hkaancaliskan hkaancaliskan mentioned this issue Nov 20, 2020
Closed
s-ankur added a commit to s-ankur/fenix that referenced this issue Dec 19, 2020
@s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
f1baf26
@nbmrjuhneibkr
Copy link

28 months later - still not fixed (94.0b4).
I'm saying "not fixed" because this is something that already worked perfectly fine in Fennec

@purpleyuan
Copy link

Are there any updates on this issue?

boek added a commit to boek/fenix that referenced this issue Dec 6, 2022
@boek @s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
cf812a5 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
boek added a commit to boek/fenix that referenced this issue Dec 6, 2022
@boek @s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
cbbf6d6 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 6, 2022
@github-actions github-actions bot mentioned this issue Dec 6, 2022
Merged
4 tasks
boek added a commit to boek/fenix that referenced this issue Dec 6, 2022
@boek @s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
3c62416 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
boek added a commit to boek/fenix that referenced this issue Dec 30, 2022
@boek @s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
70c48c0 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
boek added a commit to boek/fenix that referenced this issue Dec 30, 2022
@boek @s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
3f2ed21 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
boek added a commit to boek/fenix that referenced this issue Jan 3, 2023
@boek @s-ankur
For mozilla-mobile#3722: Invoke search on long press home button
ab3638d 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
@mergify mergify bot closed this as completed in #28101 Jan 3, 2023
mergify bot pushed a commit that referenced this issue Jan 3, 2023
@boek @s-ankur @mergify
For #3722: Invoke search on long press home button
aea7cbf 
Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
@github-actions github-actions bot reopened this Jan 3, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 3, 2023
@github-actions github-actions bot added this to the 110 milestone Jan 3, 2023
@delia-pop
Copy link

Verified as fixed on Nightly 110.0a1 from 01/04 with Google Pixel (Android 13). The keyboard is invoked and the search bar is focused when Fenix is set as digital assistant app.

a177e8a5-d304-495e-9550-445c105e75f1.mp4

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 4, 2023
@Otiel
Copy link

Otiel commented Jan 4, 2023

That is great news, thank you for fixing this! ❤️ 🥳

This was referenced Jan 31, 2023
Merged
Merged
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@boek @s-ankur @mergify
[fenix] For mozilla-mobile/fenix#3722: Invoke search on long press ho…
fc28c07 
…me button

Co-authored-by: s-ankur <s.ankursonawane@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified Feature:AndroidIntegration Feature:FennecTransition feature request 🌟 New functionality and improvements Feature:Search
Projects
None yet
Milestone
110
10 participants
@kbrosnan @Otiel @rozmansi @JoGarWeb @nbmrjuhneibkr @phileastv @purpleyuan @madb1lly @vesta0 @delia-pop