Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Deleted bookmark from a folder restored because of the undo snackbar #3967

Closed
sv-ohorvath opened this issue Jul 10, 2019 · 2 comments
Closed

[Bug] Deleted bookmark from a folder restored because of the undo snackbar #3967

sv-ohorvath opened this issue Jul 10, 2019 · 2 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Milestone
v1.4

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jul 10, 2019 •
edited by data-sync-user

Steps to reproduce

  1. Create a bookmark folder, with some bookmarks.
  2. Delete an item from the folder. (Or multiple items)
  3. Before the undo snackbar goes away, tap the back button.
  4. Return to the folder and observe the deleted bookmark(s).

Expected behavior

The items are deleted.

Actual behavior

Deleted bookmarks are back in the folder.

Device information

  • Android device: Nokia 6 (Android 7.1.1), Galaxy Note 8 (Android 9)
  • Fenix version: Nightly 190710 (#11910617)

┆Issue is synchronized with this Jira Task
@sv-ohorvath sv-ohorvath added the 🐞 bug Crashes, Something isn't working, .. label Jul 10, 2019
@sv-ohorvath sv-ohorvath added S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill Feature:Bookmarks labels Aug 2, 2019
@sv-ohorvath sv-ohorvath mentioned this issue Aug 2, 2019
Closed
@ekager ekager self-assigned this Aug 2, 2019
ekager added a commit to ekager/fenix that referenced this issue Aug 2, 2019
@ekager
For mozilla-mobile#3967 - Invokes pending deletion with more bookmark…
dbd92c0 
… actions
ekager added a commit to ekager/fenix that referenced this issue Aug 20, 2019
@ekager
For mozilla-mobile#3967 - Invokes pending deletion with more bookmark…
32d53da 
… actions
boek pushed a commit that referenced this issue Aug 21, 2019
@ekager @boek
For #3967 - Invokes pending deletion with more bookmark actions (#4522)
c1b1c2f
@ekager ekager added the eng:qa:needed QA Needed label Aug 21, 2019
@ekager ekager added this to the v1.4 milestone Aug 21, 2019
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Aug 22, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 22, 2019

Hi @ekager , this is still reproducible on debug build 1.0.1934 from 22/8 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)

►Video from Google Pixel 3a (Android 9)
ezgif com-video-to-gif (3)

ekager added a commit to ekager/fenix that referenced this issue Aug 23, 2019
@ekager
For mozilla-mobile#3967 - Invoke pending deletion on back pressed
8403c10
ekager added a commit that referenced this issue Aug 23, 2019
@ekager
For #3967 - Invoke pending deletion on back pressed
ffbbe11
@ekager ekager added the eng:qa:needed QA Needed label Aug 23, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 26, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 26, 2019

Hi, verified as fixed on The latest Nightly Build #12380610 from 26/8 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 lite (android 8.1.0)
• Samsung Glaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (android 5.1.1)

► Video Google Pixel 3a
ezgif com-video-to-gif

@AndiAJ AndiAJ closed this as completed Aug 26, 2019
@AndiAJ AndiAJ mentioned this issue Aug 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@sv-ohorvath @ekager @AndiAJ