Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Re-enable opening links in external apps. #4114

Closed
jhugman opened this issue Jul 17, 2019 · 1 comment · Fixed by #4117
Closed

Re-enable opening links in external apps. #4114

jhugman opened this issue Jul 17, 2019 · 1 comment · Fixed by #4117
Projects
A-C: Android Intent URLs
Milestone
v1.1

Comments

@jhugman
Copy link
Contributor

jhugman commented Jul 17, 2019 •
edited by data-sync-user
Loading

This is flipping the interceptLinkClicks in the AppLinksFeature constructor.

This should only be for non-http links (i.e. custom schemes and intent:// schemes).

┆Issue is synchronized with this Jira Task
@jhugman
Copy link
Contributor Author

jhugman commented Jul 17, 2019 •
edited
Loading

This is identical to ac#3687; we should keep that open before enabling everywhere.

jhugman added a commit that referenced this issue Jul 17, 2019
@jhugman
Closes #4114 - Re-enable app-links
df2b039
@jhugman jhugman mentioned this issue Jul 17, 2019
Merged
4 tasks
ekager pushed a commit that referenced this issue Jul 17, 2019
@jhugman @ekager
Closes #4114 - Re-enable app-links
90dd0ab
@colintheshots colintheshots added this to the v1.1 milestone Jul 23, 2019
@makotom makotom mentioned this issue Jul 30, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
A-C: Android Intent URLs
  
Awaiting triage
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Closes #4114 - Re-enable app-links for non-http schemes. mozilla-mobile/fenix
2 participants
@jhugman @colintheshots