Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] After sharing link and going to homescreen on fresh profile, onboarding appears #4198

Closed
lborgman opened this issue Jul 20, 2019 · 8 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. needs:investigation P2 Upcoming release S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill

Comments

@lborgman
Copy link

lborgman commented Jul 20, 2019

Steps to reproduce

  1. From another browser (Chrome) choose "Share" from the menus.

  2. Click "Firefox Preview".

Expected behavior

The same URL should open on Firefox Preview.

Actual behavior

The home page in Firefox Preview is opened instead.

(This of course makes it harder to test Firefox Preview! 😟)

Device information

  • Android device: Motorola One Vision.

  • Fenix version: Android 9

┆Issue is synchronized with this Jira Task

@lborgman lborgman added the 🐞 bug Crashes, Something isn't working, .. label Jul 20, 2019
@yoasif
Copy link
Contributor

yoasif commented Jul 20, 2019

When I tried this, it did open the shared URL, but as a new unfocused tab.

If Fenix was already open to a tab, it works as you would expect - opening a tab and switching focus to it.

@boek boek added needs:investigation S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill P2 Upcoming release labels Jul 23, 2019
@lobontiumira
Copy link

I was able to reproduce with the latest Nightly build 190730 (#12110609). The exact STR are:

  1. Make sure Firefox Preview has a clean profile,
  2. Go to Reference Browser / Firefox / Chrome etc and share a link to Firefox Preview.
  3. Firefox PReview is opened, but the Onboarding tour is displayed, not the shared link.

Reproducible with Motorola Nexus 6 (Android 7.1.1), Huawei P9 Lite (Android 6).

@ekager ekager self-assigned this Jul 30, 2019
@ekager ekager added the eng:qa:needed QA Needed label Jul 31, 2019
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Jul 31, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 31, 2019

Hi, still happening on Nightly Build #12112106 from 31/7 using a OnePlus A3 (Android 6.0.1)

@ekager Could you please help me regarding another matter?
On other devices, e.g. Google Pixel 3a (Android 9) after sharing a tab from Chrome to Fenix the tab opens as is supposed to, but if I press the tab count icon the on-boarding screen shows up.
Should the on-boarding screen still be present?

► Video from OnePlus A3
20190731_123209

► Video from Google Pixel 3a (Android 9)
20190731_123002

@ekager
Copy link
Contributor

ekager commented Jul 31, 2019

I think the onboarding should show the first time you visit the homescreen. Can we get a confirmation from UX?

@ekager ekager added the needs:UX-feedback Needs UX Feedback label Jul 31, 2019
@ekager
Copy link
Contributor

ekager commented Jul 31, 2019

@AndiAJ you're still seeing the shared link not open in browser? Or are you just seeing the onboarding when you go to home like the last comment above? ^

@lime124
Copy link
Collaborator

lime124 commented Aug 1, 2019

@apbitner for comment. he's at onboarding this week so he won't get to this until next week. thanks!

@lime124 lime124 removed the needs:UX-feedback Needs UX Feedback label Aug 1, 2019
@ekager ekager changed the title [Bug] Share doesn't open link [Bug] After sharing link and going to homescreen on fresh profile, onboarding appears Aug 1, 2019
@ekager
Copy link
Contributor

ekager commented Aug 1, 2019

This has morphed into a different issue, so I have renamed it

@ekager
Copy link
Contributor

ekager commented Aug 2, 2019

We think this is expected behavior. We want to show onboarding the first time a user is on the homescreen. I'm closing this for now.

@ekager ekager closed this as completed Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. needs:investigation P2 Upcoming release S1 Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Projects
None yet
Development

No branches or pull requests

8 participants