Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] [a11y] The tap area for Open tabs' new tab and 3 dot menu buttons is too small #4221

Closed
sv-ohorvath opened this issue Jul 22, 2019 · 1 comment
Closed

[Bug] [a11y] The tap area for Open tabs' new tab and 3 dot menu buttons is too small #4221

sv-ohorvath opened this issue Jul 22, 2019 · 1 comment
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen P2 Upcoming release
Milestone
v1.2

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Jul 22, 2019 •
edited by data-sync-user

Steps to reproduce

Running the accessibility scanner on the Fenix homescreen.

Expected behavior

Larger buttons/tap area for the New tab button and the 3 dots menu. Recommended by the A11y scanner: 48x48dp

Actual behavior

The current item's size is 24dp. Persons with large thumbs having trouble touching the 2 buttons.

Device information

  • Android device: Pixel 3
  • Fenix version: 7/22

┆Issue is synchronized with this Jira Task
@sv-ohorvath sv-ohorvath added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. labels Jul 22, 2019
@sv-ohorvath sv-ohorvath changed the title [Bug] The tap area for Open tabs' new tab and 3 dot menu buttons is too small [Bug] [a11y] The tap area for Open tabs' new tab and 3 dot menu buttons is too small Jul 22, 2019
@boek boek added the P2 Upcoming release label Jul 23, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Jul 25, 2019
@mcarare
fixes mozilla-mobile#4221 - The tap area for Open tabs' new tab and 3…
56a2bde 
… dot menu buttons is too small

changes size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
mcarare added a commit to mcarare/fenix that referenced this issue Jul 25, 2019
@mcarare
fixes mozilla-mobile#4221 - The tap area for Open tabs' new tab and 3…
c3c7c1a 
… dot menu buttons is too small

changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
@boek boek added the eng:qa:needed QA Needed label Jul 31, 2019
@boek boek closed this as completed in 30ecbc6 Jul 31, 2019
boek pushed a commit that referenced this issue Jul 31, 2019
@mcarare @boek
fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu butt…
fa8199f 
…ons is too small

changed size of buttons to 48X48 following Material Design Accessibility guidelines.
removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top
@boek boek added this to the v1.2 milestone Jul 31, 2019
@boek boek reopened this Jul 31, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 1, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Aug 1, 2019

Hi, verified as fixed on RC 1.2.0-rc.1 from 1/8 using a Google Pixel 3a (Android 9).

@AndiAJ AndiAJ closed this as completed Aug 1, 2019
@AndiAJ AndiAJ mentioned this issue Aug 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen P2 Upcoming release
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
3 participants
@boek @sv-ohorvath @AndiAJ