This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
[Bug] [a11y] Delete Tab icon from collections is too small #4434
Assignees
Labels
access
Accessibility: Talkback, HW keyboard/mouse, braile display etc.
🐞 bug
Crashes, Something isn't working, ..
eng:qa:verified
QA Verified
S1
Blocks development/testing, may impact more than 25% of users, causes data loss, potential chemspill
Milestone
Comments
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Aug 1, 2019
…cessible. set recommended minimum size for accessibility 48x48, while keeping image size the same removed margin from button as it was not needed anymore aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible implemented same visual solution as for mozilla-mobile#4193 - close button for tabs
AndiAJ
added
access
|
I agree, it's also not just the close button, but the webpage's icon, too and the text is cut off earlier due to padding (less characters for the maximum title length than an open tab), even though the overall size of the tab entry is the same. |
mcarare
added a commit
to mcarare/fenix
that referenced
this issue
Aug 12, 2019
… more accessible and aligned 3 dot menu with individual tabs close button set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same removed margins from buttons as they were not needed anymore aligned center of menu buttons with center of collection icon constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
|
Hi, verified as fixed on 1.3.0-rc.1 using a Huawei Media Pad M3 Lite 10 (Android 7) |
|
Also verified as fixed on RC 1.3.0-rc.3 with Xiaomi Mi 8Lite (Android 9). |
|
should I open a new issue for the stuff I mentioned? because that's not fixed, yet. |
|
@Djfe yes, please open a separate ticket if you're still having issues :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Prerequisites
You have a collection with a couple of tabs saved.
You have Talkback option enabled from your Android settings.
Steps to reproduce
Expected behavior
The sign can be easily tapped
Actual behavior
Difficult to tap it because of its size, could make an improvement as per #4221.
Device information
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: