Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove Quick Action Bar - Toolbar iteration #4281

Closed
12 of 13 tasks
lime124 opened this issue Jul 24, 2019 · 15 comments
Closed
12 of 13 tasks

Remove Quick Action Bar - Toolbar iteration #4281

lime124 opened this issue Jul 24, 2019 · 15 comments
Assignees
@severinrudie
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:MainMenu The three-dot menu that is seen on the browser and homescreen.
Projects
Fenix Feature Maturity Fenix Q4 Feature Backlog
Milestone
v3.1

Comments

@lime124
Copy link
Collaborator

lime124 commented Jul 24, 2019 •
edited by data-sync-user
Loading

Why/User Benefit/User Problem

After the MVP, we should take a look at the feedback coming and see what we need to iterate on. Collecting several toolbar menu related issues here for UX to consider and tackle at the same time.

Acceptance Criteria

  • Remove Quick Action Bar
  • Add Reader mode, open in app, bookmark icon, share icon to the browser menu
  • Ignore the "install to homescreen" for now (PWA)
  • Update the snackbars to be pinned to the browser toolbar and not the quick action bar.
    • AFAICT, snackbars are already being pinned to the toolbar. This may have been a missed AC in an earlier story, or I could be mistaken.
  • Comment in Dynamically update menu to show dynamic items like Reader Mode #6275 with an estimate of how much work dynamic menu update would be

This does NOT include dynamically updating the menu when it's open #6275

Reference Issues

UX

Abstract: https://share.goabstract.com/7cd59d53-ad3a-4b33-8131-74703c1859a2

┆Issue is synchronized with this Jira Task
@lime124 lime124 added the Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. label Jul 24, 2019
@lime124
Copy link
Collaborator Author

lime124 commented Jul 24, 2019

@vesta0 FYI for prioritization

@vesta0 vesta0 removed this from Could in Fenix Q3 Feature Backlog Sep 13, 2019
@apbitner apbitner self-assigned this Sep 24, 2019
@lime124 lime124 added this to To be Triaged in Fenix Sprint Kanban via automation Sep 24, 2019
@lime124 lime124 moved this from To be Triaged to Prioritized UX Backlog in Fenix Sprint Kanban Sep 24, 2019
@apbitner
Copy link

QAB will be removed for now, so as part of this work we need to account for QAB features that need to be move to the toolbar menu.

@lime124 lime124 mentioned this issue Sep 25, 2019
Closed
This was referenced Sep 27, 2019
Closed
Closed
@lime124 lime124 moved this from Prioritized UX Backlog to In Design in Fenix Sprint Kanban Sep 27, 2019
@topotropic topotropic removed their assignment Oct 2, 2019
@vesta0 vesta0 removed this from Could in Fenix Q4 Feature Backlog Oct 3, 2019
@cadeyrn cadeyrn mentioned this issue Oct 3, 2019
Closed
This was referenced Oct 3, 2019
Closed
Closed
@lime124 lime124 added the ux:s label Oct 3, 2019
@lime124
Copy link
Collaborator Author

lime124 commented Oct 10, 2019

designs being wrapped up and should be done by end of sprint tomorrow (Friday)

@apbitner apbitner added the eng:ready Ready for engineering label Oct 11, 2019
@apbitner apbitner removed their assignment Oct 11, 2019
@vesta0 vesta0 moved this from In Design to Prioritized Feature Backlog in Fenix Sprint Kanban Oct 11, 2019
@vesta0 vesta0 added must and removed could labels Oct 16, 2019
severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 6, 2019
@severinrudie
For mozilla-mobile#4281: small ToolbarMenu refactor
b920a2c 
This makes it easier to see how items are ordered in the menuItems list
This was referenced Nov 7, 2019
Closed
Closed
severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 7, 2019
@severinrudie
For mozilla-mobile#4281: small ToolbarMenu refactor
4b1c998 
This makes it easier to see how items are ordered in the menuItems list
severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 8, 2019
@severinrudie
For mozilla-mobile#4281: small ToolbarMenu refactor
f4020e2 
This makes it easier to see how items are ordered in the menuItems list
@liuche liuche modified the milestones: v3.0, v3.1 Nov 8, 2019
@severinrudie severinrudie mentioned this issue Nov 8, 2019
Closed
@severinrudie
Copy link
Contributor

Opened mozilla-mobile/android-components#5022 requesting support for toggleable, highlightable menu items.

severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 11, 2019
@severinrudie
For mozilla-mobile#4281: small ToolbarMenu refactor
7de5261 
This makes it easier to see how items are ordered in the menuItems list
severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 11, 2019
@severinrudie
For mozilla-mobile#4281: small ToolbarMenu refactor
1c3cf55 
This makes it easier to see how items are ordered in the menuItems list
severinrudie pushed a commit that referenced this issue Nov 12, 2019
4281 remove qab (#6310)
6909a76 
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

mozilla-mobile/android-components#4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
#6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 12, 2019
@severinrudie
For mozilla-mobile#4281: fixed metrics.yaml for QAB removal
8ee8781
severinrudie added a commit to severinrudie/fenix that referenced this issue Nov 12, 2019
@severinrudie
For mozilla-mobile#4281: fixed metrics.yaml for QAB removal
e0012fd
severinrudie pushed a commit that referenced this issue Nov 12, 2019
For #4281: fixed metrics.yaml for QAB removal (#6555)
f0468f8
@severinrudie severinrudie added the eng:qa:needed QA Needed label Nov 12, 2019
@project-bot project-bot bot moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Nov 12, 2019
@sv-ohorvath
Copy link
Contributor

  • 'appearance' is shown in this mock. It's a FAB that is only shown while reader mode is active.

@baron-severin was this omitted or is it followed-up in another issue?

@severinrudie
Copy link
Contributor

  • 'appearance' is shown in this mock. It's a FAB that is only shown while reader mode is active.

@baron-severin was this omitted or is it followed-up in another issue?

Sorry about that @sv-ohorvath, we neglected to document this. We ran into technical challenges with adding the FAB, so for now 'appearance' is (when available) shown as a menu item beneath reader mode. We'll be changing it in a follow-up.

@sv-ohorvath
Copy link
Contributor

Verified as fixed on Nightly 11/15.

Fenix Q4 Feature Backlog automation moved this from Must to Done! Nov 15, 2019
@project-bot project-bot bot moved this from Ready for QA to Sprint 11.2 Done in Fenix Sprint Kanban Nov 15, 2019
@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 15, 2019
@project-bot project-bot bot moved this from Sprint 11.2 Done to Sprint Backlog in Fenix Sprint Kanban Nov 15, 2019
@project-bot project-bot bot moved this from Sprint Backlog to Sprint 11.2 Done in Fenix Sprint Kanban Nov 15, 2019
@yoasif yoasif mentioned this issue Nov 15, 2019
Closed
@NotWoods NotWoods mentioned this issue Nov 25, 2019
Closed
@severinrudie severinrudie mentioned this issue Dec 24, 2019
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@severinrudie severinrudie

Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:MainMenu The three-dot menu that is seen on the browser and homescreen.
Projects
No open projects
Fenix Feature Maturity
Q4 2019
Fenix Q4 Feature Backlog
  
Done!
Milestone
v3.1
Development

No branches or pull requests
7 participants
@lime124 @topotropic @liuche @sv-ohorvath @severinrudie @apbitner @vesta0