Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4281: fixed metrics.yaml for QAB removal #6555

Merged

Conversation

severinrudie
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I'm not 100% sure how to do is, rebuild and include the changes in the metrics.md file (that are generated). It's not a big deal, it'll get picked up in a subsequent push, but ideally should be included in this PR.

@severinrudie
Copy link
Contributor Author

One thing that I'm not 100% sure how to do is, rebuild and include the changes in the metrics.md file (that are generated). It's not a big deal, it'll get picked up in a subsequent push, but ideally should be included in this PR.

Good call. Updated with that file included.

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #6555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6555   +/-   ##
=========================================
  Coverage     16.66%   16.66%           
  Complexity      349      349           
=========================================
  Files           271      271           
  Lines         10615    10615           
  Branches       1472     1472           
=========================================
  Hits           1769     1769           
  Misses         8699     8699           
  Partials        147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6909a76...e0012fd. Read the comment docs.

@severinrudie severinrudie merged commit f0468f8 into mozilla-mobile:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants