Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Some download file names truncated inappropriately #4336

Closed
neekless opened this issue Jul 27, 2019 · 2 comments · Fixed by #4296
Closed

[Bug] Some download file names truncated inappropriately #4336

neekless opened this issue Jul 27, 2019 · 2 comments · Fixed by #4296
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Download

Comments

@neekless
Copy link
Contributor

neekless commented Jul 27, 2019

Trying to download files with periods in their name will have everything after the first period truncated.

Steps to reproduce

Many ways to trigger this but for the sake of testing try downloading these 2 files:

  1. https://www.apkmirror.com/apk/google-inc/messenger-google-inc/messenger-google-inc-4-7-056-release/messages-4-7-056-kraken_rc13_xxxhdpi-arm64-v8a-phone-android-apk-download/download/

  2. https://download.msfjarvis.website/caesium/wahoo/beta/Caesium-wahoo-v3.6-b792615ced1b.zip

Expected behavior

Actual file names are:

  1. com.google.android.apps.messaging_4.7.056_(Kraken_RC13_xxxhdpi.arm64-v8a.phone)-47056249_minAPI21(arm64-v8a)(560,640dpi)_apkmirror.com.apk.

  2. Caesium-wahoo-v3.6-b792615ced1b.zip

These are also the file names when downloaded on other browsers (Chrome, Firefox desktop, etc).

Actual behavior

In fenix the downloaded file names are:

  1. com.apk

  2. Caesium-wahoo-v3.zip

Device information

  • Android device: Pixel 2XL Android 9
  • Fenix version: Nightly 190726 06:03 (Build #12070610) 📦: 6.0.0 🦎: 68.0-20190711090008 (but has been happening for a few versions now)

Could mozilla-mobile/android-components@b2a1f28 be related?

This is a huge problem in my opinion as most apk downloads are named com.apk and files with version numbers in their name (e.g. v3.1.zip and v3.2.zip) also get the same name (v3.zip).

Screenshot_Firefox_Preview_20190727-075729
Screenshot_Firefox_Preview_20190726-094241

┆Issue is synchronized with this Jira Task

@neekless neekless added the 🐞 bug Crashes, Something isn't working, .. label Jul 27, 2019
@NotWoods
Copy link
Contributor

This will get fixed when we transition to the new Gecko download manager (#4296). I'll look into fixing it for the current download manager as well.

@NotWoods
Copy link
Contributor

Fixed in Android Components 6.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Download
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants