Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #1657 - Use Gecko for downloads #4296

Merged
merged 2 commits into from
Aug 3, 2019
Merged

Closes #1657 - Use Gecko for downloads #4296

merged 2 commits into from
Aug 3, 2019

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Jul 25, 2019 •
edited
Loading

Turns on the new gecko based downloader.

Also:

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@NotWoods NotWoods requested a review from a team as a code owner July 25, 2019 15:14
pocmo
pocmo reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait. I just saw a related crash in RB. Will file now.

@pocmo
Copy link
Contributor

pocmo commented Jul 25, 2019 •
edited
Loading

mozilla-mobile/android-components#3900

EDIT: Fixed ✅

@NotWoods NotWoods mentioned this pull request Jul 28, 2019
Closed
@boek
Copy link
Contributor

boek commented Jul 30, 2019

Let's land this after the 1.2 release branch gets cut so this cane bake on Nightly for some time 👍

@NotWoods
Copy link
Contributor Author

NotWoods commented Aug 1, 2019

Now that we've cut 1.2 should this get merged?

@ekager
Copy link
Contributor

ekager commented Aug 3, 2019

Let's do it!

@ekager ekager merged commit cbd811d into mozilla-mobile:master Aug 3, 2019
@Amejia481 Amejia481 mentioned this pull request Aug 28, 2019
Closed
@NotWoods NotWoods deleted the gecko-download branch January 25, 2020 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo left review comments

@ekager ekager ekager approved these changes

Assignees
No one assigned
Labels
Feature:Download
Projects
None yet
Milestone
No milestone
4 participants
@NotWoods @pocmo @boek @ekager