Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

More descriptive instructions for search shortcuts #4664

Closed
Verdi opened this issue Aug 9, 2019 · 6 comments
Closed

More descriptive instructions for search shortcuts #4664

Verdi opened this issue Aug 9, 2019 · 6 comments
Assignees
Labels
eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:Search

Comments

@Verdi
Copy link

Verdi commented Aug 9, 2019

Steps to reproduce

  1. Click into search field
  2. Search shortcuts are displayed and preceded by the words, "Search with."

Let's try to make this feature more understandable and use the words that we're using in the new desktop design - "This time, search with:"

New Expected behavior

  1. Click into search field
  2. Search shortcuts are displayed and preceded by the words, "This time, search with:"

┆Issue is synchronized with this Jira Task

@sblatz
Copy link
Contributor

sblatz commented Aug 14, 2019

Adding "feature request" label so Vesta sees this in her triage!

@sblatz sblatz added the feature request 🌟 New functionality and improvements label Aug 14, 2019
@neekless
Copy link
Contributor

neekless commented Sep 3, 2019

I would rather have the option to turn this off completely. I set my search engine to a specific one for a reason and I don't need all these other search engines I'm never gonna use to show by default. If I want to use other search engines I'll tap the Shortcuts button myself.

@mcarare mcarare added this to Polish Bugs to Triage in Feature Polish via automation Nov 26, 2019
@athomasmoz athomasmoz moved this from Polish Bugs to Triage to Prioritized Backlog in Feature Polish Nov 27, 2019
@severinrudie
Copy link
Contributor

I would rather have the option to turn this off completely. I set my search engine to a specific one for a reason and I don't need all these other search engines I'm never gonna use to show by default. If I want to use other search engines I'll tap the Shortcuts button myself.

Hi @neekless, that option is available at Settings -> Search -> uncheck "Show search shortcuts"

@neekless
Copy link
Contributor

@baron-severin yes I have noticed this and unchecked it since some versions ago, but thanks for letting me know!

@mcarare
Copy link
Contributor

mcarare commented Nov 29, 2019

This seems a little verbose to me. Can we try another string? Maybe shorter but still sufficiently descriptive?

@severinrudie severinrudie moved this from Prioritized Backlog to In progress in Feature Polish Dec 3, 2019
boek added a commit to boek/fenix that referenced this issue Dec 3, 2019
boek added a commit to boek/fenix that referenced this issue Dec 3, 2019
@severinrudie severinrudie moved this from In progress to Ready for QA in Feature Polish Dec 3, 2019
ekager pushed a commit to boek/fenix that referenced this issue Dec 3, 2019
@mcarare mcarare moved this from Ready for QA to In Dev Review in Feature Polish Dec 6, 2019
severinrudie pushed a commit to boek/fenix that referenced this issue Dec 6, 2019
@severinrudie severinrudie moved this from In Dev Review to Ready for QA in Feature Polish Dec 6, 2019
@severinrudie severinrudie added the eng:qa:needed QA Needed label Dec 14, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 16, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 16, 2019

Hi, verified as fixed on the latest Nightly Build #13500610 from 12/16 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Screenshot
rsz_screenshot_20191216-120729

@AndiAJ AndiAJ closed this as completed Dec 16, 2019
Feature Polish automation moved this from Ready for QA to Done Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Feature:Search
Projects
No open projects
Development

No branches or pull requests

8 participants