Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4664 - Updates search_with string. #6909

Merged

Conversation

boek
Copy link
Contributor

@boek boek commented Dec 3, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@boek
Copy link
Contributor Author

boek commented Dec 3, 2019

image

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9feb048). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6909   +/-   ##
========================================
  Coverage          ?   18.6%           
  Complexity        ?     413           
========================================
  Files             ?     282           
  Lines             ?   11165           
  Branches          ?    1524           
========================================
  Hits              ?    2077           
  Misses            ?    8926           
  Partials          ?     162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feb048...832ae47. Read the comment docs.

@ekager ekager changed the title For #4664 - Updates search_with string. For #4664 - Updates search_with string Dec 3, 2019
@ekager ekager added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Dec 3, 2019
@ekager ekager force-pushed the i4664-update_search_with_string branch from 1738f70 to 4f162b6 Compare December 3, 2019 12:08
@ekager ekager changed the title For #4664 - Updates search_with string For #4664 - Updates search_with string. Dec 3, 2019
@severinrudie severinrudie force-pushed the i4664-update_search_with_string branch from 4f162b6 to 832ae47 Compare December 6, 2019 17:02
@severinrudie severinrudie merged commit 4fb26a0 into mozilla-mobile:master Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants