Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor HomeFragment to be more testable #4744

Closed
sblatz opened this issue Aug 14, 2019 · 1 comment
Closed

Refactor HomeFragment to be more testable #4744

sblatz opened this issue Aug 14, 2019 · 1 comment
Labels
eng:health Improve code health P3 Some future sprint

Comments

@sblatz
Copy link
Contributor

sblatz commented Aug 14, 2019

Currently there is a lot of code in HomeFragment that cannot be tested because it needs to be abstracted out. Let's refactor this code out and write some tests for it 馃槃

鈹咺ssue is synchronized with this Jira Task

@sblatz sblatz added P3 Some future sprint eng:health Improve code health labels Aug 14, 2019
@NotWoods
Copy link
Contributor

NotWoods commented Aug 16, 2019

Some suggestions:

  • Move BrowserSessionsObserver to its own file.
  • Uplift getting only normal/only private sessions to Android Components.
  • Move the search engine icon (in the search bar) to its own custom view, or move the entire search bar.
    • Maybe Android Components should have a search bar with icon component.
  • Move toolbarPaddingDp to dimens.xml.
  • Move the private browsing button to a custom view
  • Move preDrawListener to a custom class that implements LifecycleObserver.
  • handleTabAction/handleCollectionAction should be moved somewhere else, maybe an interactor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health P3 Some future sprint
Projects
None yet
Development

No branches or pull requests

3 participants