Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4744 - Extract TransitionPreDrawListener #4812

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

NotWoods
Copy link
Contributor

Extracts the onPreDraw listener from HomeFragment.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@NotWoods NotWoods requested a review from a team as a code owner August 19, 2019 14:20
@codecov-io
Copy link

Codecov Report

Merging #4812 into master will increase coverage by 0.02%.
The diff coverage is 19.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4812      +/-   ##
===========================================
+ Coverage      6.37%    6.4%   +0.02%     
- Complexity      154     157       +3     
===========================================
  Files           205     206       +1     
  Lines          9022    9027       +5     
  Branches       1358    1357       -1     
===========================================
+ Hits            575     578       +3     
- Misses         8401    8403       +2     
  Partials         46      46
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/mozilla/fenix/home/TransitionPreDrawListener.kt 33.33% <33.33%> (ø) 3 <3> (?)
app/src/main/java/org/mozilla/fenix/ext/Context.kt 12% <0%> (-4%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d02354...c8fbf49. Read the comment docs.

@boek boek merged commit b8c9310 into mozilla-mobile:master Aug 19, 2019
@NotWoods NotWoods deleted the home-pre-draw-listener branch January 25, 2020 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants