Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Media Notifications aren't displayed #5290

Closed
AndiAJ opened this issue Sep 13, 2019 · 22 comments
Closed

[Bug] Media Notifications aren't displayed #5290

AndiAJ opened this issue Sep 13, 2019 · 22 comments
Assignees
@rocketsroger
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media needs:ac Needs Android Component Work P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 13, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Navigate to Spotify and play a song
  2. Lock the device screen
  3. Press the power button an check the lockscreen

Expected behavior

Media notification should be displayed

Actual behavior

No media notification is displayed

Device information

  • Android device: Samsung Galaxy Tab A (android 9)
  • Fenix version: 2.0.0-rc.2

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Media S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Sep 13, 2019
@AndiAJ AndiAJ changed the title [Bug]Spotify Media Notification isn't sidplayed on lock screen [Bug]Spotify Media Notification isn't displayed on lock screen Sep 13, 2019
@ekager
Copy link
Contributor

ekager commented Sep 17, 2019

Is this the same as #5177 ?

@pocmo
Copy link
Contributor

pocmo commented Sep 25, 2019

Possible. Let's see after #5177 is fixed.

@pocmo pocmo mentioned this issue Sep 25, 2019
Closed
@pocmo pocmo self-assigned this Sep 25, 2019
@pocmo
Copy link
Contributor

pocmo commented Sep 27, 2019

#5177 was fixed and the fix should be in Nightly. This can be retested now.

@pocmo pocmo added the eng:qa:needed QA Needed label Sep 27, 2019
@pocmo pocmo added this to the v2.2 milestone Sep 27, 2019
@sv-ohorvath
Copy link
Contributor

Still no media notification from spotify.com on the latest Nightly 10/8 build.

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label Oct 8, 2019
@pocmo
Copy link
Contributor

pocmo commented Oct 8, 2019

Thanks! I'll continue debugging this.

@pocmo
Copy link
Contributor

pocmo commented Oct 8, 2019

Okay, how do I actually play something on spotify in the browser? On desktop I can go to open.spotify.com - but that doesn't seem to work when using a mobile browser?

@sv-ohorvath
Copy link
Contributor

@pocmo I just logged in, picked a playlist from the homepage and tapped a song. You don't have the shuffle play option like on desktop though.

@sv-ohorvath
Copy link
Contributor

@vesta0 this appears to be included in the 2.2 milestone but it's not done yet.

@vesta0 vesta0 removed this from the v2.2 milestone Oct 17, 2019
@lobontiumira
Copy link

Reproducible on RC 2.3.0-rc.2 build on Xiaomi Mi Pad 2 (Android 5.1) - x86-64 architecture.

@boek boek added needs:ac Needs Android Component Work P3 Some future sprint labels Dec 28, 2019
@ekager
Copy link
Contributor

ekager commented Apr 11, 2020

Just retested this. I'm not seeing any notification displayed for Spotify. (Neither in the toolbar or on the homescreen)
STR:

  1. Go to open.spotify.com.
  2. Ignore their "Open in Spotify" buttons and just click one of the albums to play a song

@ekager ekager changed the title [Bug]Spotify Media Notification isn't displayed on lock screen [Bug] Spotify Media Notification isn't displayed Apr 11, 2020
@lobontiumira
Copy link

I reproduced this issue playing videos from bbc.com, cnn.com, vimeo.com, on the latest Beta 80.0.0-beta.4 build, with Samsung Galaxy Tab S6 (Android 9), and OnePlus A3 (Android 6.0.1).

  • Not reproducible on the latest Nightly build from 8/7.

@AndiAJ AndiAJ changed the title [Bug] Spotify Media Notification isn't displayed [Bug] Spotify and BBC Media Notification isn't displayed Aug 7, 2020
@AndiAJ AndiAJ changed the title [Bug] Spotify and BBC Media Notification isn't displayed [Bug] Media Notifications aren't displayed Aug 7, 2020
@pocmo
Copy link
Contributor

pocmo commented Aug 7, 2020

There will be a new MediaControl/MediaSession API in GeckoView soon. Android Components will switch to that and that should hopefully resolve a lot of issues. In the meantime we probably won't do any changes to the existing code anymore since that will probably all go away.
https://bugzilla.mozilla.org/show_bug.cgi?id=1623715

@Poopooracoocoo Poopooracoocoo mentioned this issue Sep 5, 2020
Closed
@dbolter
Copy link

dbolter commented Sep 25, 2020

FYI I happened to notice 1623715 landed so this should be unblocked. (Note: I'm not making any claims as to priority here)

@ekager ekager added the eng:qa:needed QA Needed label Sep 25, 2020
@pocmo pocmo removed the eng:qa:needed QA Needed label Sep 28, 2020
@pocmo
Copy link
Contributor

pocmo commented Sep 28, 2020

We are currently working on integrating the new GV API into AC.

@kbrosnan kbrosnan mentioned this issue Oct 7, 2020
Closed
@mcarare mcarare mentioned this issue Oct 28, 2020
Closed
@sv-ohorvath
Copy link
Contributor

Still reproducing no notification of media playing shown in the status bar or in tabs tray, with sample videos from:
http://techslides.com/sample-webm-ogg-and-mp4-video-files-for-html5
https://file-examples.com/index.php/sample-video-files/

@sv-ohorvath sv-ohorvath mentioned this issue Feb 16, 2021
Closed
@pocmo
Copy link
Contributor

pocmo commented Feb 16, 2021

Okay, this is now definitely the new API. :)

@rocketsroger: Can you investigate? Maybe we need to open a GV bug if we do not get anything for those sites.

@rocketsroger
Copy link
Contributor

Okay, this is now definitely the new API. :)

@rocketsroger: Can you investigate? Maybe we need to open a GV bug if we do not get anything for those sites.

Sure, I'll look into this.

@rocketsroger rocketsroger assigned rocketsroger and unassigned pocmo Feb 16, 2021
@rocketsroger
Copy link
Contributor

rocketsroger commented Feb 16, 2021 •
edited
Loading

Yes, I can reproduce the issue with https://file-examples.com/index.php/sample-video-files/
But I can't reproduce for http://techslides.com/sample-webm-ogg-and-mp4-video-files-for-html5. Media notification is shown. (short amount of time since the video is short)

@rocketsroger
Copy link
Contributor

https://file-examples.com/index.php/sample-video-files/ is an interesting case. On both Chrome and Sample browser this results in a downloading of the file selected. But on Fenix we play it directly. Not sure if this is an expected behaviour. I'll investigate more.

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Feb 17, 2021 •
edited
Loading

Yes, I can reproduce the issue with https://file-examples.com/index.php/sample-video-files/
But I can't reproduce for http://techslides.com/sample-webm-ogg-and-mp4-video-files-for-html5. Media notification is shown. (short amount of time since the video is short)

You're right, I see the notification from techslides.com as well now. The same video formats (which play in the browser, not downloading) on https://www.learningcontainer.com/mp4-sample-video-files-download/ work. It might be something with the samples on https://file-examples.com/index.php/sample-video-files/

I also have an automated media test which is playing a video from a static test page and it doesn't show a notification either. I changed the resource video file with an mp4 from https://www.learningcontainer.com/mp4-sample-video-files-download/ and it still doesn't work.

@rocketsroger
Copy link
Contributor

Confirmed with GeckoView team that this is an expected behaviour. In the https://file-examples.com/index.php/sample-video-files/ test case, except for AVI (which triggers a download) the other formats such as MOV and MP4 starts streaming. GV does not notify A-C in this case as MediaSession hence we don't have a notification.

I'll get a Bugzilla issue to link here.

@rocketsroger
Copy link
Contributor

Raised an issue for the file-example.com test case. mozilla-mobile/android-components#9748
Since the original issue here was Spotify and it now works correctly. I'll close this issue and we can track the new issue to avoid confusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media needs:ac Needs Android Component Work P3 Some future sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@pocmo @dbolter @boek @sv-ohorvath @rocketsroger @ekager @lobontiumira @vesta0 @AndiAJ