Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Talkback cannot access "common myths about private browsing" link from private browsing description #5356

Closed
mcarare opened this issue Sep 16, 2019 · 2 comments
Closed

[Bug] Talkback cannot access "common myths about private browsing" link from private browsing description #5356

mcarare opened this issue Sep 16, 2019 · 2 comments
Assignees
@mcarare
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing
Milestone
v2.1

Comments

@mcarare
Copy link
Contributor

mcarare commented Sep 16, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

Launch Fenix with Talkback active.
Switch to private browsing
Access "common myths about private browsing" link

Expected behavior

The link can receive focus and be accessed

Actual behavior

The link cannot receive focus andTalkback users cannot access it

Device information

  • Android device: Any
  • Fenix version: 1.0.1938

┆Issue is synchronized with this Jira Task
@mcarare mcarare added the 🐞 bug Crashes, Something isn't working, .. label Sep 16, 2019
@mcarare mcarare self-assigned this Sep 16, 2019
@mcarare
Copy link
Contributor Author

mcarare commented Sep 16, 2019

Similar to #5141

@mcarare mcarare mentioned this issue Sep 16, 2019
Merged
4 tasks
@mcarare mcarare added access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:PrivateBrowsing labels Sep 16, 2019
mcarare added a commit to mcarare/fenix that referenced this issue Sep 23, 2019
@mcarare
For mozilla-mobile#5356 Improved private browsing "common myths" link…
45d0b3f 
… accessibility

Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
sblatz pushed a commit that referenced this issue Sep 24, 2019
@mcarare @sblatz
For #5356 Improves private browsing "common myths" link accessibility (…
c7c752c 
…#5479)

Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
@sblatz sblatz added the eng:qa:needed QA Needed label Sep 24, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 24, 2019
@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from PlayStore 190925 (#12681805) with Samsung Galaxy Note 8 (Android 9), Huawei Honor 8 (Android 7), and LG G7 Fit (Android 8.1).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
3 participants
@sblatz @lobontiumira @mcarare