Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5356 Improved private browsing "common myths" link accessibility #5479

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Sep 23, 2019

Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

… accessibility

Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
@mcarare mcarare requested review from a team as code owners September 23, 2019 08:20
@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #5479 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #5479      +/-   ##
===========================================
+ Coverage     13.09%   13.1%   +<.01%     
  Complexity      289     289              
===========================================
  Files           252     252              
  Lines         10367   10365       -2     
  Branches       1504    1504              
===========================================
  Hits           1358    1358              
+ Misses         8916    8914       -2     
  Partials         93      93
Impacted Files Coverage Δ Complexity Δ
...iewholders/PrivateBrowsingDescriptionViewHolder.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0574511...45d0b3f. Read the comment docs.

@mcarare mcarare changed the title For #5356 Improved private browsing "common myths" link accessibility For #5356 Improved private browsing "common myths" link accessibility Sep 23, 2019
Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and looks good to me. Thanks for this patch 😄

@sblatz sblatz merged commit c7c752c into mozilla-mobile:master Sep 24, 2019
@mcarare mcarare deleted the 5356 branch October 28, 2019 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants